NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-09-09 03:25:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(custom_netmiko): use

Browse Source 
assertIs instead of assertEqual for class comparison

   Fix test failures in custom Netmiko driver tests by using assertIs instead
   of assertEqual when comparing class objects registered in CLASS_MAPPER.

   The issue occurred because test files add project root to sys.path, allowing
   the same module to be imported with different paths (e.g., gns3_copilot...
   vs gns3server.agent.gns3_copilot...). assertEqual compares class __module__
   attributes which differ based on import path, while assertIs checks object
   identity which correctly identifies them as the same class.

   Modified files:
   - test_huawei_ce.py
   - test_ruijie_telnet.py
   - test_vpcs_telnet.py
This commit is contained in:
YueGuobin 2026-03-17 21:24:39 +08:00
parent bd06d3a08e
commit a240620443
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py
View File

@ -51,14 +51,14 @@ class TestHuaweiTelnetCEDriver(unittest.TestCase):
# Check CLASS_MAPPER
self.assertIn("gns3_huawei_telnet_ce", CLASS_MAPPER)
self.assertEqual(
self.assertIs(
CLASS_MAPPER["gns3_huawei_telnet_ce"],
self.HuaweiTelnetCE
)
# Check CLASS_MAPPER_BASE
self.assertIn("gns3_huawei_telnet_ce", CLASS_MAPPER_BASE)
self.assertEqual(
self.assertIs(
CLASS_MAPPER_BASE["gns3_huawei_telnet_ce"],
self.HuaweiTelnetCE
)

4
gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py
View File

@ -51,14 +51,14 @@ class TestRuijieTelnetEnhancedDriver(unittest.TestCase):
# Check CLASS_MAPPER
self.assertIn("gns3_ruijie_telnet", CLASS_MAPPER)
self.assertEqual(
self.assertIs(
CLASS_MAPPER["gns3_ruijie_telnet"],
self.RuijieTelnetEnhanced
)
# Check CLASS_MAPPER_BASE
self.assertIn("gns3_ruijie_telnet", CLASS_MAPPER_BASE)
self.assertEqual(
self.assertIs(
CLASS_MAPPER_BASE["gns3_ruijie_telnet"],
self.RuijieTelnetEnhanced
)

4
gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py
View File

@ -53,14 +53,14 @@ class TestVPCSTelnetDriver(unittest.TestCase):
# Check CLASS_MAPPER
self.assertIn("gns3_vpcs_telnet", CLASS_MAPPER)
self.assertEqual(
self.assertIs(
CLASS_MAPPER["gns3_vpcs_telnet"],
self.VPCSTelnet
)
# Check CLASS_MAPPER_BASE
self.assertIn("gns3_vpcs_telnet", CLASS_MAPPER_BASE)
self.assertEqual(
self.assertIs(
CLASS_MAPPER_BASE["gns3_vpcs_telnet"],
self.VPCSTelnet
)