From a2406204431b67838b9b85b3bd0d45431548fb1c Mon Sep 17 00:00:00 2001 From: YueGuobin Date: Tue, 17 Mar 2026 21:24:39 +0800 Subject: [PATCH] fix(custom_netmiko): use assertIs instead of assertEqual for class comparison Fix test failures in custom Netmiko driver tests by using assertIs instead of assertEqual when comparing class objects registered in CLASS_MAPPER. The issue occurred because test files add project root to sys.path, allowing the same module to be imported with different paths (e.g., gns3_copilot... vs gns3server.agent.gns3_copilot...). assertEqual compares class __module__ attributes which differ based on import path, while assertIs checks object identity which correctly identifies them as the same class. Modified files: - test_huawei_ce.py - test_ruijie_telnet.py - test_vpcs_telnet.py --- .../gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py | 4 ++-- .../utils/custom_netmiko/tests/test_ruijie_telnet.py | 4 ++-- .../utils/custom_netmiko/tests/test_vpcs_telnet.py | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py index 62a1c3a5c..a5a06157b 100644 --- a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py +++ b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py @@ -51,14 +51,14 @@ class TestHuaweiTelnetCEDriver(unittest.TestCase): # Check CLASS_MAPPER self.assertIn("gns3_huawei_telnet_ce", CLASS_MAPPER) - self.assertEqual( + self.assertIs( CLASS_MAPPER["gns3_huawei_telnet_ce"], self.HuaweiTelnetCE ) # Check CLASS_MAPPER_BASE self.assertIn("gns3_huawei_telnet_ce", CLASS_MAPPER_BASE) - self.assertEqual( + self.assertIs( CLASS_MAPPER_BASE["gns3_huawei_telnet_ce"], self.HuaweiTelnetCE ) diff --git a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py index 682050c9e..4fe72b21a 100644 --- a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py +++ b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py @@ -51,14 +51,14 @@ class TestRuijieTelnetEnhancedDriver(unittest.TestCase): # Check CLASS_MAPPER self.assertIn("gns3_ruijie_telnet", CLASS_MAPPER) - self.assertEqual( + self.assertIs( CLASS_MAPPER["gns3_ruijie_telnet"], self.RuijieTelnetEnhanced ) # Check CLASS_MAPPER_BASE self.assertIn("gns3_ruijie_telnet", CLASS_MAPPER_BASE) - self.assertEqual( + self.assertIs( CLASS_MAPPER_BASE["gns3_ruijie_telnet"], self.RuijieTelnetEnhanced ) diff --git a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py index 64700e139..1b4eb9b4f 100644 --- a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py +++ b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py @@ -53,14 +53,14 @@ class TestVPCSTelnetDriver(unittest.TestCase): # Check CLASS_MAPPER self.assertIn("gns3_vpcs_telnet", CLASS_MAPPER) - self.assertEqual( + self.assertIs( CLASS_MAPPER["gns3_vpcs_telnet"], self.VPCSTelnet ) # Check CLASS_MAPPER_BASE self.assertIn("gns3_vpcs_telnet", CLASS_MAPPER_BASE) - self.assertEqual( + self.assertIs( CLASS_MAPPER_BASE["gns3_vpcs_telnet"], self.VPCSTelnet )