7075 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
YueGuobin	dc3a386961	Add MCP tool parameter consistency tests	2026-06-17 23:59:40 +08:00
YueGuobin	ead9747e1b	Fix appliance_install: add version parameter	2026-06-17 23:03:28 +08:00
Jeremy Grossmann	2e75c9319b	Merge pull request #2787 from yueguobin/optimize/project-open-speed ... Performance: accelerate project opening with parallel link creation and batch UDP port allocation	2026-06-16 23:59:41 +02:00
YueGuobin	f16eba183a	Add coordinate system note to docs	2026-06-16 23:30:59 +08:00
YueGuobin	0d21f294f6	Document canvas coordinate system in node_create x/y params	2026-06-16 23:16:17 +08:00
YueGuobin	00647d092c	Update docstring: batch concurrency from 10 to 100	2026-06-16 23:05:17 +08:00
YueGuobin	da35eaa014	Remove unused import time	2026-06-16 23:04:05 +08:00
YueGuobin	10ff5b2283	Add list type check before nodes[0] access in _normalize_link_nodes	2026-06-16 23:00:47 +08:00
YueGuobin	0d45bfbae5	Add fields type validation in create handlers	2026-06-16 22:58:36 +08:00
YueGuobin	390a40ce80	Use pop() instead of pop(0) for O(1) port removal	2026-06-16 22:56:42 +08:00
YueGuobin	59e5f8dd2f	Fix review issues: key_prefix length, count validation, WAL log, timeout comment, pointless temp var	2026-06-16 22:50:22 +08:00
YueGuobin	533d3d5b71	Fix: pass name from TemplateUsage to add_node_from_template ... The controller endpoint received name via TemplateUsage but never passed it to add_node_from_template, causing the name parameter to be silently ignored. name is optional - if omitted the template's default_name_format is used.	2026-06-16 22:43:46 +08:00
YueGuobin	68567118f1	Remove unused imports (logging, log, select)	2026-06-16 22:25:07 +08:00
YueGuobin	af94c1729b	Add warning for unconsumed pre-allocated UDP ports after link creation ... Ports are properly released on project close (compute.post /close). The warning alerts if any pre-allocated ports go unused within a session.	2026-06-16 22:22:46 +08:00
Jeremy Grossmann	7d5d4767bf	Remove FIXME comment about middleware in server.py ... Removed commented out FIXME note regarding middleware issues.	2026-06-16 12:20:55 +02:00
YueGuobin	f7abb62603	Rename device_command_run_handler → device_show_run_handler to match tool name	2026-06-16 12:44:12 +08:00
YueGuobin	fbb8924a8e	Rename device_command_run → device_show_run for clarity ... The name device_command_run was ambiguous and easily confused with device_config_send. device_show_run makes the read-only intent explicit, forming a clear pair: config_send (write) vs show_run (read).	2026-06-16 12:27:35 +08:00
YueGuobin	e627481ec2	Fix device_command_run KeyError('commands'): tool desc said show_commands but backend expects commands ... - Tool description and param schema now use 'commands' (matching ExecuteMultipleDeviceCommands) - Updated error message in handler - Clarified in docstring that this is read-only; use device_config_send for config changes	2026-06-16 12:23:15 +08:00
YueGuobin	ec58bea24b	Fix template_list return type annotation to match _run_handler_sync envelope ... template_list was annotated as dict[str, Any] but _run_handler_sync always returns a list envelope ([{"type":"text",...}]). Other tools use list[dict[str, Any]] consistently. This caused a Pydantic dict_type validation error on the client.	2026-06-16 12:08:07 +08:00
YueGuobin	a126f910d4	Add performance optimization documentation	2026-06-16 01:14:12 +08:00
YueGuobin	48b7ea8bf0	Update MCP service docs: API key format, auth flow, tool parameters, concurrency	2026-06-16 01:13:01 +08:00
YueGuobin	d407b29fe9	Increase HTTP connection pool to 500/1000	2026-06-16 00:58:12 +08:00
YueGuobin	74192f454f	Increase BATCH_MAX_WORKERS and Pool concurrency from 20 to 100	2026-06-16 00:49:08 +08:00
YueGuobin	286b2407cd	Remove final timing artifact in projects.py	2026-06-16 00:44:54 +08:00
YueGuobin	bd15c8d019	Remove remaining dead timing variables and imports	2026-06-16 00:40:03 +08:00
YueGuobin	a8cc01af46	Remove database warmup (proven ineffective - real bottleneck was bcrypt blocking event loop)	2026-06-16 00:35:42 +08:00
YueGuobin	ccb629f48f	Clean up all timing/debug logs ... Remove all [MCP-TIMING] and [CTRL-TIMING] log lines, timing middleware, and related import time statements across 11 files.	2026-06-16 00:34:11 +08:00
YueGuobin	8ef70d9fac	Add memory: import validation best practice	2026-06-16 00:25:45 +08:00
YueGuobin	7d8ab399da	Fix: add missing UUID imports	2026-06-16 00:24:37 +08:00
YueGuobin	d6b337bc3a	Generate fresh JWT on API key auth instead of returning raw key ... When MCP client authenticates with API key, _resolve_token now returns a newly generated JWT. This JWT is stored in the ContextVar and used by all subsequent tool handler API calls - zero extra bcrypt.	2026-06-16 00:09:36 +08:00
YueGuobin	f522c947bc	Optimize API key auth: O(1) lookup via UUID-embedded key format ... New format: gns3_<api_key_id>_<random_secret> - Auth extracts api_key_id from token → single DB query by UUID → one bcrypt - No more scanning all keys (was O(n) with bcrypt per key) - bcrypt.checkpw offloaded to thread pool to prevent event loop blocking - Legacy gns3_<random> format removed (compatibility break)	2026-06-15 23:56:36 +08:00
YueGuobin	796a2e6ca8	Fix: offload bcrypt.checkpw to thread pool to prevent blocking event loop ... bcrypt.checkpw is CPU-bound (~1.3s per call) and was running synchronously inside the async event loop, blocking ALL concurrent requests. With 5 API keys and 10 concurrent requests, this caused ~13s delay before any handler could start.	2026-06-15 23:49:28 +08:00
YueGuobin	04f0657661	Add timing to API key auth path and log api_keys count	2026-06-15 23:45:26 +08:00
YueGuobin	3c41dea48f	Replace SELECT 1 warmup with full database file read to warm OS page cache ... Reading the entire DB file into OS page cache eliminates the 8-14s cold-start penalty on the first ORM query (users/templates/api_keys). Previous SELECT 1 only warmed the connection pool, not the file cache.	2026-06-15 23:43:41 +08:00
YueGuobin	5502b8f8e5	Add timing logs to auth dependency chain to identify 6s pre-handler delay	2026-06-15 23:35:12 +08:00
YueGuobin	b3619a3c00	Add granular timing to get_template: separate execute vs fetch time	2026-06-15 23:33:19 +08:00
YueGuobin	e90fb0774c	Warm up database connection pool on startup to avoid 8s cold-start penalty on first API request	2026-06-15 23:26:28 +08:00
YueGuobin	6d3cfc7d1e	Fix: register WAL PRAGMA on sync_engine instead of Engine class for async compat ... - Move event listener from module-level @Engine to engine.sync_engine - Add WAL mode verification log on startup - Remove unused Engine class-level listener	2026-06-15 23:21:50 +08:00
YueGuobin	08e0dbc122	Add timing logs to get_template to identify DB query bottleneck	2026-06-15 23:18:00 +08:00
YueGuobin	fa9aa5a9cc	Add timing middleware to log slow requests (>1s) with [CTRL-TIMING] prefix	2026-06-15 23:13:36 +08:00
YueGuobin	a855cb34f1	Fix: _time → time in compute.py timing log	2026-06-15 23:06:10 +08:00
YueGuobin	ea4bb2c1fb	Add [CTRL-TIMING] logs to controller create_node flow ... Timing logs cover: - create_node_from_template (entry, get_template, add_node, total) - add_node_from_template (entry to done) - _create_node (project_setup, node.create, total) - Node.create (compute_post timing) - compute._session.request (actual HTTP to compute)	2026-06-15 23:04:01 +08:00
YueGuobin	e5797c3da0	Fix: pass template_id to batch mode handler so top-level template_id works as default	2026-06-15 22:57:40 +08:00
YueGuobin	cef6dc6bd2	Add detailed timing logs to MCP node creation and HTTP client ... Logs with [MCP-TIMING] prefix at: - create_node_handler entry, setup, http_call start/end, total - http_call entry, auth, response - _authenticate_v3 entry, done, fail	2026-06-15 22:51:43 +08:00
YueGuobin	58ca6b1dd4	Add fields filter to template_list tool with description for AI	2026-06-15 22:11:14 +08:00
YueGuobin	b79fb89866	Fix: add missing _filter_link_response function ... Previously the function was referenced in create_link_handler but never defined, causing NameError at runtime.	2026-06-15 21:51:17 +08:00
YueGuobin	1bb010d274	Pass name parameter through to controller API when creating node from template	2026-06-15 21:50:14 +08:00
YueGuobin	eb3ac64016	Add validation to compact link format with clear error messages ... - Validate array length (must be exactly 6) - Validate node_id types at positions 0 and 3 - Return descriptive errors so AI can self-correct	2026-06-15 21:46:27 +08:00
YueGuobin	a8a83051ff	Add compact array format for link node entries to reduce token usage ... Supports both standard and compact formats: Standard: [{"node_id": "uuid", "adapter_number": 0, "port_number": 0}] Compact: ["uuid", 0, 0, "uuid", 0, 0] - 3x less tokens	2026-06-15 21:42:26 +08:00
YueGuobin	27a489a3fd	Add fields filter to link_create tool ... - Default response: link_id, link_type, nodes (3 fields vs full 13) - Available fields listed in tool description for AI	2026-06-15 13:50:04 +08:00