NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-09-01 06:50:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix: revert IOU lock optimization, serialize IOU node creation for correct application_id assignment

Browse Source 
The _iou_id_lock must cover _create_node() because get_next_application_id()
checks in-memory nodes (self._nodes), which are only registered after
_create_node() completes. Without this serialization, concurrent IOU
node creation produces duplicate application IDs.
This commit is contained in:
YueGuobin 2026-06-15 12:49:01 +08:00
parent 5d0284e7be
commit e29e02a8c6
No known key found for this signature in database
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gns3server/controller/project.py
View File

@ -620,18 +620,17 @@ class Project:
if node_type == "iou":
async with self._iou_id_lock:
# Only hold the lock while allocating a unique application ID to avoid
# serializing the HTTP call to the compute across all IOU nodes.
# Multiple IOU nodes can be created concurrently once IDs are assigned.
# IOU application IDs must be allocated serially to avoid duplicates.
# The lock must also cover _create_node() because get_next_application_id()
# checks in-memory nodes (self._nodes), which are only registered
# after _create_node() completes.
if "properties" in kwargs.keys():
# allocate a new application id for nodes loaded from the project
kwargs.get("properties")["application_id"] = get_next_application_id(
self._controller.projects, self._computes
)
elif "application_id" not in kwargs.keys() and not kwargs.get("properties"):
# allocate a new application id for nodes added to the project
kwargs["application_id"] = get_next_application_id(self._controller.projects, self._computes)
node = await self._create_node(compute, name, node_id, node_type, **kwargs)
node = await self._create_node(compute, name, node_id, node_type, **kwargs)
else:
node = await self._create_node(compute, name, node_id, node_type, **kwargs)
self.emit_notification("node.created", node.asdict())