NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-08-27 12:30:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(statistics): handle closed projects where nodes/links are dicts

Browse Source 
Open projects store Node/Link objects, but closed projects store
dictionaries loaded from topology JSON. This fix checks the type
before accessing attributes.
This commit is contained in:
YueGuobin 2026-03-29 23:59:17 +08:00
parent 8b4c3a3517
commit b4caffe13b
No known key found for this signature in database
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
gns3server/api/routes/controller/controller.py
View File

@ -194,8 +194,15 @@ async def statistics() -> dict:
node_by_type = {}
node_by_status = {}
for node in all_nodes:
node_by_type[node.node_type] = node_by_type.get(node.node_type, 0) + 1
node_by_status[node.status] = node_by_status.get(node.status, 0) + 1
# Handle both Node objects (open project) and dicts (closed project)
if isinstance(node, dict):
node_type = node.get("node_type", "unknown")
node_status = node.get("status", "unknown")
else:
node_type = getattr(node, "node_type", "unknown")
node_status = getattr(node, "status", "unknown")
node_by_type[node_type] = node_by_type.get(node_type, 0) + 1
node_by_status[node_status] = node_by_status.get(node_status, 0) + 1
node_stats = {
"total": len(all_nodes),
@ -208,7 +215,14 @@ async def statistics() -> dict:
for project in projects:
all_links.extend(project.links.values())
link_capturing = sum(1 for link in all_links if getattr(link, "capturing", False))
def is_capturing(link):
if hasattr(link, "capturing"):
return link.capturing
if isinstance(link, dict):
return link.get("capturing", False)
return False
link_capturing = sum(1 for link in all_links if is_capturing(link))
link_stats = {
"total": len(all_links),