Merge pull request #2913 from markparonyan/mypy-schemas-compute-nodes

fix(typing): resolve mypy errors in schemas.compute node schemas

gns3server/schemas/compute/atm_switch_nodes.py

@@ -26,8 +26,8 @@ class ATMSwitchBase(BaseModel):
     Common ATM switch properties.
     """
 
-    name: str = None
-    node_id: UUID = None
+    name: Optional[str] = None
+    node_id: Optional[UUID] = None
     usage: Optional[str] = None
     mappings: Optional[dict] = None
 

gns3server/schemas/compute/dynamips_nodes.py

@@ -124,7 +124,6 @@ class DynamipsBase(BaseModel):
     node_id: Optional[UUID] = None
     name: Optional[str] = None
     dynamips_id: Optional[int] = Field(None, description="Dynamips internal ID")
-    platform: Optional[DynamipsPlatform] = Field(None, description="Cisco router platform")
     ram: Optional[int] = Field(None, gt=0, description="Amount of RAM in MB")
     nvram: Optional[int] = Field(None, gt=0, description="Amount of NVRAM in KB")
     image: Optional[str] = Field(None, description="Path to the IOS image")
@@ -185,11 +184,12 @@ class DynamipsUpdate(DynamipsBase):
     Properties to update a Dynamips node.
     """
 
-    pass
+    platform: Optional[DynamipsPlatform] = Field(None, description="Cisco router platform")
 
 
 class Dynamips(DynamipsBase):
     name: str
+    platform: Optional[DynamipsPlatform] = Field(None, description="Cisco router platform")
     node_id: UUID
     project_id: UUID
     dynamips_id: int

gns3server/schemas/compute/nat_nodes.py

@@ -89,7 +89,7 @@ class NATBase(BaseModel):
     Common NAT node properties.
     """
 
-    name: str
+    name: Optional[str] = None
     node_id: Optional[UUID] = None
     usage: Optional[str] = None
     ports_mapping: Optional[List[Union[EthernetPort, TAPPort, UDPPort]]] = Field(
@@ -102,7 +102,7 @@ class NATCreate(NATBase):
     Properties to create a NAT node.
     """
 
-    pass
+    name: str
 
 
 class NATUpdate(NATBase):
@@ -110,10 +110,11 @@ class NATUpdate(NATBase):
     Properties to update a NAT node.
     """
 
-    name: Optional[str] = None
+    pass
 
 
 class NAT(NATBase):
+    name: str
     project_id: UUID
     node_id: UUID
     ports_mapping: List[Union[EthernetPort, TAPPort, UDPPort]]