From 094fcf27479b8fc1567df41904f3ee872c942473 Mon Sep 17 00:00:00 2001 From: Mark Paronyan Date: Mon, 28 Sep 2026 05:15:05 +0000 Subject: [PATCH 1/3] fix(typing): resolve mypy errors in schemas.compute.atm_switch_nodes --- gns3server/schemas/compute/atm_switch_nodes.py | 4 ++-- pyproject.toml | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/gns3server/schemas/compute/atm_switch_nodes.py b/gns3server/schemas/compute/atm_switch_nodes.py index 9a9db0845..9d126bfe9 100644 --- a/gns3server/schemas/compute/atm_switch_nodes.py +++ b/gns3server/schemas/compute/atm_switch_nodes.py @@ -26,8 +26,8 @@ class ATMSwitchBase(BaseModel): Common ATM switch properties. """ - name: str = None - node_id: UUID = None + name: Optional[str] = None + node_id: Optional[UUID] = None usage: Optional[str] = None mappings: Optional[dict] = None diff --git a/pyproject.toml b/pyproject.toml index 258447eb6..093342909 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -374,13 +374,10 @@ module = [ "gns3server.db.repositories.templates", # 6 "gns3server.db.repositories.users", # 12 "gns3server.db.tasks", # 12 - "gns3server.schemas.compute.atm_switch_nodes", # 5 "gns3server.schemas.compute.cloud_nodes", # 1 "gns3server.schemas.compute.docker_nodes", # 2 - "gns3server.schemas.compute.dynamips_nodes", # 1 "gns3server.schemas.compute.frame_relay_switch_nodes", # 5 "gns3server.schemas.compute.iou_nodes", # 3 - "gns3server.schemas.compute.nat_nodes", # 1 "gns3server.schemas.compute.qemu_nodes", # 1 "gns3server.schemas.compute.virtualbox_nodes", # 2 "gns3server.schemas.compute.vmware_nodes", # 3 From 672ef2e3cec155adb361a7660d91ef75920e3070 Mon Sep 17 00:00:00 2001 From: Mark Paronyan Date: Mon, 28 Sep 2026 04:48:29 +0000 Subject: [PATCH 2/3] fix(typing): resolve mypy errors in schemas.compute.dynamips_nodes --- gns3server/schemas/compute/dynamips_nodes.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gns3server/schemas/compute/dynamips_nodes.py b/gns3server/schemas/compute/dynamips_nodes.py index d01020a28..6292b400b 100644 --- a/gns3server/schemas/compute/dynamips_nodes.py +++ b/gns3server/schemas/compute/dynamips_nodes.py @@ -124,7 +124,6 @@ class DynamipsBase(BaseModel): node_id: Optional[UUID] = None name: Optional[str] = None dynamips_id: Optional[int] = Field(None, description="Dynamips internal ID") - platform: Optional[DynamipsPlatform] = Field(None, description="Cisco router platform") ram: Optional[int] = Field(None, gt=0, description="Amount of RAM in MB") nvram: Optional[int] = Field(None, gt=0, description="Amount of NVRAM in KB") image: Optional[str] = Field(None, description="Path to the IOS image") @@ -185,11 +184,12 @@ class DynamipsUpdate(DynamipsBase): Properties to update a Dynamips node. """ - pass + platform: Optional[DynamipsPlatform] = Field(None, description="Cisco router platform") class Dynamips(DynamipsBase): name: str + platform: Optional[DynamipsPlatform] = Field(None, description="Cisco router platform") node_id: UUID project_id: UUID dynamips_id: int From a3c4c954315b8b06961a69d0f908bb208e434d9e Mon Sep 17 00:00:00 2001 From: Mark Paronyan Date: Mon, 28 Sep 2026 04:47:28 +0000 Subject: [PATCH 3/3] fix(typing): resolve mypy errors in schemas.compute.nat_nodes --- gns3server/schemas/compute/nat_nodes.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gns3server/schemas/compute/nat_nodes.py b/gns3server/schemas/compute/nat_nodes.py index 95a703320..e3c569251 100644 --- a/gns3server/schemas/compute/nat_nodes.py +++ b/gns3server/schemas/compute/nat_nodes.py @@ -89,7 +89,7 @@ class NATBase(BaseModel): Common NAT node properties. """ - name: str + name: Optional[str] = None node_id: Optional[UUID] = None usage: Optional[str] = None ports_mapping: Optional[List[Union[EthernetPort, TAPPort, UDPPort]]] = Field( @@ -102,7 +102,7 @@ class NATCreate(NATBase): Properties to create a NAT node. """ - pass + name: str class NATUpdate(NATBase): @@ -110,10 +110,11 @@ class NATUpdate(NATBase): Properties to update a NAT node. """ - name: Optional[str] = None + pass class NAT(NATBase): + name: str project_id: UUID node_id: UUID ports_mapping: List[Union[EthernetPort, TAPPort, UDPPort]]