mirror of
https://github.com/GNS3/gns3-server.git
synced 2026-10-13 14:05:36 +03:00
c7ffe919dc
A VPCS node's single adapter anchors on a persistent TAP the server
creates (tap create + set_owner via uBridge) and the vpcs process
attaches to by name: -e -d <gp{id8}e0p0> -n, the same
server-creates/guest-attaches shape as QEMU's netdev. -n (a vpcs fork
feature) keeps the guest's ip command from ifconfig'ing the anchor on
the host; the vpcs build is probed once per binary identity
(vpcs_tap capability, usage scan) and gates kernel links together
with ubridge_tap — anything else keeps the node on the relay (the
legacy local UDP tunnel on a stock binary, an AF_PACKET endpoint on
the anchor with a capable one).
VPCSVM takes KernelDatapathMixin: _connect_nio dispatches kernel
(enslave into the per-link bridge) / relay-on-anchor / legacy,
captures pick capture start_kernel vs the bridge engine, stop runs
under an execute lock and terminates the process before deleting the
anchor TAPs (a held device refuses deletion), and the duplicate-port
guard backstops the controller's. The NIO routes accept nio_bridge
and write suspend back on update.
_delete_anchor_taps verifies each tap is gone from sysfs and retries
a bounded three times: a holder can release its fd a moment after its
process was reaped (vpcs's daemon parent kills its console child and
exits first), so the unconditional delete raced EBUSY and leaked the
anchor intermittently.
The vpcs side needs IFNAMSIZ (16) instead of its own IFNAMESIZ (12)
for the -d name buffer — anchor names are 14 chars and truncated to a
nonexistent device, which TUNSETIFF then tries to create without
CAP_NET_ADMIN (fixed in the vpcs fork).
e2e (tests/e2e/test_vpcs_kernel_datapath.py): kernel and relay
scenarios green against the real binary — real ICMP both ways, §E.1/§
E.2 on the anchors, delay/suspend/capture, link delete/re-create,
node stop/restart self-heal, zero leftovers; the relay control passes
with both the fork binary and a stock one.
79 lines
2.4 KiB
Python
79 lines
2.4 KiB
Python
#
|
|
# Copyright (C) 2026 GNS3 Technologies Inc.
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
import os
|
|
import stat
|
|
|
|
import pytest
|
|
|
|
from gns3server.compute.vpcs.vpcs_probe import probe_vpcs_tap
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
|
|
def _fake_vpcs(path, usage):
|
|
path.write_text(f"#!/bin/sh\ncat <<'EOF'\n{usage}\nEOF\n")
|
|
mode = path.stat().st_mode | stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH
|
|
os.chmod(path, mode)
|
|
|
|
|
|
async def test_probe_reports_dash_n_build(config, tmp_path):
|
|
|
|
binary = tmp_path / "vpcs"
|
|
_fake_vpcs(
|
|
binary,
|
|
" -d device device name, works only when -i is set to 1\n"
|
|
" -n do not auto-configure the host tap interface\n",
|
|
)
|
|
config.settings.VPCS.vpcs_path = str(binary)
|
|
assert await probe_vpcs_tap() is True
|
|
|
|
|
|
async def test_probe_reports_upstream_build(config, tmp_path):
|
|
|
|
binary = tmp_path / "vpcs"
|
|
_fake_vpcs(
|
|
binary,
|
|
" -d device device name, works only when -i is set to 1\n",
|
|
)
|
|
config.settings.VPCS.vpcs_path = str(binary)
|
|
assert await probe_vpcs_tap() is False
|
|
|
|
|
|
async def test_probe_reports_missing_binary(config, tmp_path):
|
|
|
|
config.settings.VPCS.vpcs_path = str(tmp_path / "does-not-exist")
|
|
assert await probe_vpcs_tap() is None
|
|
|
|
|
|
async def test_probe_caches_by_binary_identity(config, tmp_path):
|
|
"""
|
|
The same binary answers once; replacing it (a different mtime/size)
|
|
re-probes.
|
|
"""
|
|
|
|
binary = tmp_path / "vpcs"
|
|
_fake_vpcs(binary, " -n do not auto-configure\n")
|
|
config.settings.VPCS.vpcs_path = str(binary)
|
|
assert await probe_vpcs_tap() is True
|
|
|
|
# replace with a build without the flag: the binary identity changed,
|
|
# so the cached True must not answer
|
|
_fake_vpcs(binary, " -d device device name\n")
|
|
os.utime(binary, (0, 0))
|
|
assert await probe_vpcs_tap() is False
|