mirror of
https://github.com/GNS3/gns3-server.git
synced 2026-11-19 20:55:14 +02:00
The copilot and the MCP service maintained two parallel wrapper layers (LangChain BaseTool classes vs @mcp.tool() functions) over the same handlers in gns3_client/api_handlers.py. Descriptions and parameters drifted apart (compute_id and link_type were missing on the copilot side). This makes the MCP registration the single source of truth and removes the duplicated wrappers. tools_v2/mcp_bridge.py adapts the MCP server's tool registration into LangChain tools: names, descriptions and argument schemas come from the MCP tools. The pool is filtered to project-scoped tools (MCP_ALLOWED_TOOLS) because the copilot runs inside one open project — project management, compute/appliance/image administration and server info tools stay out. The bridge carries the copilot's request JWT into the MCP contextvars (username/token_version decoded from the token so ticket-minting tools work) and runs the async MCP functions from the copilot's sync tool node on either thread flavor. Mode toolsets (teaching / lab_automation / troubleshooting_injection) are now composed from adapted MCP tools plus a few copilot-native ones that add value the MCP versions lack: link_create (port-name resolution), wait_seconds, packet_analysis(+skills), and the topology reader. Eight orphaned LangChain wrappers are deleted. The device command tools had the dependency inverted (the MCP handlers instantiated the copilot LangChain classes and round-tripped through JSON strings). The Nornir/Netmiko classes moved verbatim (git mv) into the shared layer as plain runners — DeviceConfigCommandRunner, DeviceShowCommandRunner, VpcsCommandRunner — with _run(json_string) becoming run(params, gns3_ctx). The optional Jinja2 template rendering moved from the MCP handlers into the runners (and into utils/device_configs.render_device_template), so both entry paths get it; the MCP handlers are now pure delegation. This also drops the json.dumps/json.loads detour the MCP path used to take. test_tool_params consistency gate extended: a handler that forwards the whole params dict to a callee is a wildcard (same rationale as the params.items() case) — the per-key check cannot see through delegation.
197 lines
6.5 KiB
Python
197 lines
6.5 KiB
Python
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
#
|
|
# GNS3-Copilot - AI-powered Network Lab Assistant for GNS3
|
|
#
|
|
# This file is part of GNS3-Copilot project.
|
|
#
|
|
# GNS3-Copilot is free software: you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by the
|
|
# Free Software Foundation, either version 3 of the License, or (at your
|
|
# option) any later version.
|
|
#
|
|
# GNS3-Copilot is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
|
|
# or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
# for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with GNS3-Copilot. If not, see <https://www.gnu.org/licenses/>.
|
|
#
|
|
# Copyright (C) 2025 Yue Guobin (岳国宾)
|
|
# Author: Yue Guobin (岳国宾)
|
|
#
|
|
# Project Home: https://github.com/yueguobin/gns3-copilot
|
|
#
|
|
|
|
"""
|
|
Tests for the copilot ← MCP tool bridge (tools_v2/mcp_bridge.py).
|
|
|
|
The bridge reuses the MCP server's tool registration as the single source
|
|
of truth for the copilot's LangChain tools. These tests pin the filter
|
|
(project-scoped allowlist, no administration tools), the drift guard on
|
|
requested names, the args-model generation, and the sync/async context
|
|
bridging.
|
|
"""
|
|
|
|
import asyncio
|
|
import json
|
|
from typing import Any
|
|
|
|
import pytest
|
|
|
|
from gns3server.agent.gns3_copilot.tools_v2 import mcp_bridge
|
|
from gns3server.agent.gns3_copilot.tools_v2.mcp_bridge import (
|
|
MCP_ALLOWED_TOOLS,
|
|
NATIVE_TOOL_NAMES,
|
|
_run_coro_sync,
|
|
_unwrap_mcp_content,
|
|
adapted_mcp_tools,
|
|
)
|
|
|
|
|
|
def test_allowlist_excludes_administration_tools() -> None:
|
|
"""The copilot runs inside one project: management tools stay out."""
|
|
banned = {
|
|
"project_list",
|
|
"project_create",
|
|
"project_delete",
|
|
"project_open",
|
|
"project_close",
|
|
"template_create",
|
|
"template_update",
|
|
"template_delete",
|
|
"compute_list",
|
|
"compute_get",
|
|
"appliance_list",
|
|
"appliance_install",
|
|
"image_list",
|
|
"image_delete",
|
|
"image_prune",
|
|
"server_version",
|
|
"server_statistics",
|
|
}
|
|
assert banned & MCP_ALLOWED_TOOLS == set()
|
|
|
|
|
|
def test_every_allowed_tool_exists_on_the_mcp_server() -> None:
|
|
"""The allowlist must not reference tools the MCP server does not register."""
|
|
from gns3server.agent.mcp import mcp
|
|
|
|
registered = {tool.name for tool in mcp._tool_manager.list_tools()}
|
|
assert MCP_ALLOWED_TOOLS <= registered
|
|
|
|
|
|
def test_adapted_pool_is_allowlist_minus_native_shadows() -> None:
|
|
tools = adapted_mcp_tools()
|
|
names = {tool.name for tool in tools}
|
|
assert names == MCP_ALLOWED_TOOLS - NATIVE_TOOL_NAMES
|
|
# link_create is served by the copilot-native wrapper (port-name
|
|
# resolution) and must not be adapted.
|
|
assert "link_create" not in names
|
|
|
|
|
|
def test_adapted_subset_preserves_order_and_drift_guard() -> None:
|
|
tools = adapted_mcp_tools(names=["node_start", "node_stop"])
|
|
assert [tool.name for tool in tools] == ["node_start", "node_stop"]
|
|
|
|
with pytest.raises(RuntimeError, match="not available to the copilot"):
|
|
adapted_mcp_tools(names=["node_start", "no_such_tool"])
|
|
|
|
|
|
def test_adapted_args_model_matches_mcp_schema() -> None:
|
|
tool = next(t for t in adapted_mcp_tools() if t.name == "node_create")
|
|
fields = tool.args_schema.model_fields
|
|
# required parameter carried over from the MCP JSON schema
|
|
assert "project_id" in fields
|
|
assert fields["project_id"].is_required()
|
|
# optional parameters keep their MCP defaults
|
|
assert fields["compute_id"].default == "local"
|
|
assert fields["x"].default == 0
|
|
# **kwargs-style MCP tools surface a plain dict "kwargs" parameter
|
|
node_update = next(t for t in adapted_mcp_tools() if t.name == "node_update")
|
|
assert "kwargs" in node_update.args_schema.model_fields
|
|
|
|
|
|
def test_unwrap_mcp_content() -> None:
|
|
assert _unwrap_mcp_content([{"type": "text", "text": json.dumps({"a": 1})}]) == {"a": 1}
|
|
assert _unwrap_mcp_content([{"type": "text", "text": "plain text"}]) == "plain text"
|
|
assert _unwrap_mcp_content({"already": "a dict"}) == {"already": "a dict"}
|
|
assert _unwrap_mcp_content("bare string") == "bare string"
|
|
|
|
|
|
def test_run_coro_sync_without_running_loop() -> None:
|
|
async def value() -> int:
|
|
return 42
|
|
|
|
assert _run_coro_sync(value()) == 42
|
|
|
|
|
|
def test_run_coro_sync_inside_running_loop() -> None:
|
|
"""Sync tool code executing on the event loop thread must still work."""
|
|
|
|
async def value() -> int:
|
|
return 7
|
|
|
|
async def main() -> int:
|
|
return _run_coro_sync(value())
|
|
|
|
assert asyncio.run(main()) == 7
|
|
|
|
|
|
class _FakeMcpTool:
|
|
"""Minimal stand-in for an mcp.server.mcpserver Tool."""
|
|
|
|
name = "fake_probe"
|
|
description = "Fake tool for bridge tests."
|
|
parameters: dict[str, Any] = {
|
|
"properties": {"x": {"type": "integer", "description": "a number"}},
|
|
"required": ["x"],
|
|
"type": "object",
|
|
}
|
|
|
|
async def fn(self, x: int) -> list[dict[str, str]]:
|
|
# Report the contextvars the bridge was supposed to set, proving
|
|
# they survived the thread/loop hop into the handler context.
|
|
from gns3server.agent.mcp import _jwt_token_var, _jwt_token_version_var, _jwt_username_var
|
|
|
|
return [
|
|
{
|
|
"type": "text",
|
|
"text": json.dumps(
|
|
{
|
|
"x": x,
|
|
"token": _jwt_token_var.get(),
|
|
"username": _jwt_username_var.get(),
|
|
"token_version": _jwt_token_version_var.get(),
|
|
}
|
|
),
|
|
}
|
|
]
|
|
|
|
|
|
class _FakeTokenData:
|
|
username = "tester"
|
|
token_version = 3
|
|
|
|
|
|
def test_invoke_bridges_copilot_context_into_mcp_handler(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
"""The copilot's JWT must reach the MCP contextvars inside the handler."""
|
|
monkeypatch.setattr(
|
|
mcp_bridge, "build_gns3_ctx", lambda: {"jwt_token": "copilot-jwt", "server_url": "http://127.0.0.1:3080"}
|
|
)
|
|
monkeypatch.setattr(mcp_bridge.auth_service, "get_token_data", lambda token: _FakeTokenData())
|
|
|
|
tool = mcp_bridge._adapt(_FakeMcpTool())
|
|
result = tool.invoke({"x": 5})
|
|
|
|
assert result == {"x": 5, "token": "copilot-jwt", "username": "tester", "token_version": 3}
|
|
|
|
|
|
def test_invoke_without_token_returns_error(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(mcp_bridge, "build_gns3_ctx", lambda: None)
|
|
|
|
tool = mcp_bridge._adapt(_FakeMcpTool())
|
|
result = tool.invoke({"x": 5})
|
|
|
|
assert "error" in result
|