mirror of
https://github.com/GNS3/gns3-server.git
synced 2026-10-12 21:45:41 +03:00
1db9f171ca
Three fixes from live-calibrating the kernel impairment filters on an isolated instance (Docker-to-Docker veth link, per-sequence evidence): - update_filters skipped an unchanged filters dict as a no-op, so a one-shot window_drop outage that had already passed could never be re-armed: re-applying the same values produced no datapath command at all. A PUT still carrying window_drop now reconciles, restarting the schedule from the apply as documented. Measured: identical re-apply moves the outage window from seq 50-70 to 70-91 (arm at +8s of the new apply). - gemodel parameter semantics were documented backwards in the validation rules, available_filters, the MCP/copilot descriptions and the feature docs. Measured against the kernel (per-direction counters, offered = sent + dropped): p is the good-to-bad transition chance, r the bad-to-good transition, 1-h the loss chance in the bad state (the good state loses nothing) - mean one-way loss p/(p+r)*(1-h), e.g. [10,30,100] -> 24.8%/25.7% measured vs 25% predicted, [5,45,100] -> 10.8% both ways vs 10%. - kernel_datapath was silently stripped from every REST/MCP link payload by the response model (LinkBase carried no such field), so clients could not tell a kernel link from a relay one. Also verified on the same setup: the 3-argument window_drop form works exactly as specified ([3000,5000,100] -> a single seq 31-55 outage, [20000,6000,100] -> seq 115-144), and both generations of the command builder emit the parameters unpadded. Adds an API test for the field and controller tests for the no-op skip and the window_drop re-arm exemption.
473 lines
15 KiB
Python
473 lines
15 KiB
Python
#!/usr/bin/env python
|
|
#
|
|
# Copyright (C) 2020 GNS3 Technologies Inc.
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
import pytest_asyncio
|
|
|
|
from gns3server.controller.controller_error import ControllerError
|
|
from gns3server.controller.link import Link
|
|
from gns3server.controller.node import Node
|
|
from gns3server.controller.ports.ethernet_port import EthernetPort
|
|
from gns3server.controller.ports.serial_port import SerialPort
|
|
from tests.utils import AsyncioBytesIO, AsyncioMagicMock
|
|
|
|
|
|
@pytest_asyncio.fixture
|
|
async def link(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 1, 3)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
await link.add_node(node2, 1, 3)
|
|
return link
|
|
|
|
|
|
def test_eq(project, link):
|
|
|
|
assert link == Link(project, link_id=link.id)
|
|
assert link != "a"
|
|
assert link != Link(project)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_add_node(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
project.dump = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
assert link._nodes == [
|
|
{
|
|
"node": node1,
|
|
"port": node1._ports[0],
|
|
"adapter_number": 0,
|
|
"port_number": 4,
|
|
"label": {
|
|
"text": "0/4",
|
|
"style": "font-family: TypeWriter;font-size: 10.0;font-weight: bold;fill: #000000;fill-opacity: 1.0;",
|
|
},
|
|
}
|
|
]
|
|
assert project.dump.called
|
|
assert not link._project.emit_notification.called
|
|
assert not link.create.called
|
|
|
|
# We call link.created only when both side are created
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
await link.add_node(node2, 0, 4)
|
|
|
|
assert link.create.called
|
|
link._project.emit_notification.assert_called_with("link.created", link.asdict())
|
|
assert link in node2.links
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_add_node_already_connected(project, compute):
|
|
"""
|
|
Raise an error if we try to use an already connected port
|
|
"""
|
|
|
|
project.dump = AsyncioMagicMock()
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
await link.add_node(node2, 0, 4)
|
|
|
|
assert link.create.called
|
|
link2 = Link(project)
|
|
link2.create = AsyncioMagicMock()
|
|
with pytest.raises(ControllerError):
|
|
await link2.add_node(node1, 0, 4)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_add_node_cloud(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="cloud")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
|
|
await link.add_node(node1, 0, 4)
|
|
await link.add_node(node2, 0, 4)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_add_node_cloud_to_cloud(project, compute):
|
|
"""
|
|
Cloud to cloud connection is not allowed
|
|
"""
|
|
|
|
node1 = Node(project, compute, "node1", node_type="cloud")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="cloud")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
|
|
await link.add_node(node1, 0, 4)
|
|
with pytest.raises(ControllerError):
|
|
await link.add_node(node2, 0, 4)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_add_node_same_node(project, compute):
|
|
"""
|
|
Connection to the same node is not allowed
|
|
"""
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4), EthernetPort("E1", 0, 0, 5)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
|
|
await link.add_node(node1, 0, 4)
|
|
with pytest.raises(ControllerError):
|
|
await link.add_node(node1, 0, 5)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_add_node_serial_to_ethernet(project, compute):
|
|
"""
|
|
Serial to ethernet connection is not allowed
|
|
"""
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [SerialPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
|
|
await link.add_node(node1, 0, 4)
|
|
with pytest.raises(ControllerError):
|
|
await link.add_node(node2, 0, 4)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_json(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 1, 3)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
await link.add_node(node2, 1, 3)
|
|
assert link.asdict() == {
|
|
"link_id": link.id,
|
|
"project_id": project.id,
|
|
"nodes": [
|
|
{
|
|
"node_id": node1.id,
|
|
"adapter_number": 0,
|
|
"port_number": 4,
|
|
"label": {
|
|
"text": "0/4",
|
|
"style": "font-family: TypeWriter;font-size: 10.0;font-weight: bold;fill: #000000;fill-opacity: 1.0;",
|
|
},
|
|
},
|
|
{
|
|
"node_id": node2.id,
|
|
"adapter_number": 1,
|
|
"port_number": 3,
|
|
"label": {
|
|
"text": "1/3",
|
|
"style": "font-family: TypeWriter;font-size: 10.0;font-weight: bold;fill: #000000;fill-opacity: 1.0;",
|
|
},
|
|
},
|
|
],
|
|
"filters": {},
|
|
"markers": {},
|
|
"show_filters_icon": True,
|
|
"link_style": {},
|
|
"suspend": False,
|
|
"wireshark": False,
|
|
"link_type": "ethernet",
|
|
"kernel_datapath": False,
|
|
"capturing": False,
|
|
"capture_file_name": None,
|
|
"capture_file_path": None,
|
|
"capture_compute_id": None,
|
|
}
|
|
assert link.asdict(topology_dump=True) == {
|
|
"link_id": link.id,
|
|
"nodes": [
|
|
{
|
|
"node_id": node1.id,
|
|
"adapter_number": 0,
|
|
"port_number": 4,
|
|
"label": {
|
|
"text": "0/4",
|
|
"style": "font-family: TypeWriter;font-size: 10.0;font-weight: bold;fill: #000000;fill-opacity: 1.0;",
|
|
},
|
|
},
|
|
{
|
|
"node_id": node2.id,
|
|
"adapter_number": 1,
|
|
"port_number": 3,
|
|
"label": {
|
|
"text": "1/3",
|
|
"style": "font-family: TypeWriter;font-size: 10.0;font-weight: bold;fill: #000000;fill-opacity: 1.0;",
|
|
},
|
|
},
|
|
],
|
|
"link_style": {},
|
|
"filters": {},
|
|
"markers": {},
|
|
"show_filters_icon": True,
|
|
"suspend": False,
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_json_serial_link(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [SerialPort("S0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [SerialPort("S0", 0, 1, 3)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
await link.add_node(node2, 1, 3)
|
|
assert link.asdict()["link_type"] == "serial"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_default_capture_file_name(project, compute):
|
|
|
|
node1 = Node(project, compute, "Hello@", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "w0.rld", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 1, 3)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
await link.add_node(node2, 1, 3)
|
|
assert link.default_capture_file_name() == "Hello_0-4_to_w0rld_1-3.pcap"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_start_capture(link):
|
|
|
|
async def fake_reader():
|
|
return AsyncioBytesIO()
|
|
|
|
link.read_pcap_from_source = fake_reader
|
|
link._project.emit_notification = MagicMock()
|
|
await link.start_capture(capture_file_name="test.pcap")
|
|
assert link._capturing
|
|
assert link._capture_file_name == "test.pcap"
|
|
link._project.emit_notification.assert_called_with("link.updated", link.asdict())
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_stop_capture(link):
|
|
|
|
link._capturing = True
|
|
link._project.emit_notification = MagicMock()
|
|
await link.stop_capture()
|
|
assert link._capturing is False
|
|
link._project.emit_notification.assert_called_with("link.updated", link.asdict())
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_delete(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
project.dump = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
await link.add_node(node2, 0, 4)
|
|
assert link in node2.links
|
|
await link.delete()
|
|
assert link not in node2.links
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_filters(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
project.dump = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
await link.add_node(node2, 0, 4)
|
|
|
|
link.update = AsyncioMagicMock()
|
|
assert link._created
|
|
await link.update_filters({"packet_loss": [10], "delay": [50, 10], "frequency_drop": [0], "bpf": [" \n "]})
|
|
assert link.filters == {"packet_loss": [10], "delay": [50, 10]}
|
|
assert link.update.called
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_filters_unchanged_is_noop(project, compute):
|
|
"""Re-sending an identical filters dict skips the datapath reconcile."""
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
project.dump = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
await link.add_node(node2, 0, 4)
|
|
|
|
link.update = AsyncioMagicMock()
|
|
await link.update_filters({"packet_loss": [10]})
|
|
assert link.update.call_count == 1
|
|
await link.update_filters({"packet_loss": [10]})
|
|
assert link.update.call_count == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_filters_unchanged_window_drop_still_reconciles(project, compute):
|
|
"""
|
|
window_drop's outage schedule is measured from the apply, so an
|
|
unchanged re-send must re-arm it instead of being skipped as a no-op.
|
|
"""
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
project.dump = AsyncioMagicMock()
|
|
await link.add_node(node1, 0, 4)
|
|
await link.add_node(node2, 0, 4)
|
|
# window_drop is kernel-only: this synthetic link has no real wiring,
|
|
# so declare the kernel datapath the way _link_data does at runtime
|
|
link._link_data = [{"type": "nio_bridge"}]
|
|
|
|
link.update = AsyncioMagicMock()
|
|
await link.update_filters({"window_drop": [3000, 5000, 100]})
|
|
assert link.update.call_count == 1
|
|
await link.update_filters({"window_drop": [3000, 5000, 100]})
|
|
assert link.update.call_count == 2
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_available_filters(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="ethernet_switch")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
assert link.available_filters() == []
|
|
|
|
# The brctl Ethernet switch hosts filters on its per-port uBridge relays
|
|
await link.add_node(node1, 0, 4)
|
|
assert len(link.available_filters()) > 0
|
|
|
|
node2 = Node(project, compute, "node2", node_type="vpcs")
|
|
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
await link.add_node(node2, 0, 4)
|
|
assert len(link.available_filters()) > 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_link_style(project, compute):
|
|
|
|
node1 = Node(project, compute, "node1", node_type="qemu")
|
|
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
|
node2 = Node(project, compute, "node2", node_type="qemu")
|
|
node2._ports = [EthernetPort("E0", 0, 1, 3)]
|
|
|
|
link = Link(project)
|
|
link.create = AsyncioMagicMock()
|
|
link._project.emit_notification = MagicMock()
|
|
project.dump = MagicMock()
|
|
|
|
await link.add_node(node1, 0, 4)
|
|
await link.add_node(node2, 1, 3)
|
|
|
|
await link.update_link_style(
|
|
{
|
|
"color": "#00ff00",
|
|
"width": 3,
|
|
"type": 1,
|
|
"link_type": "flowchart",
|
|
"bezier_curviness": 150,
|
|
"flowchart_roundness": 20,
|
|
}
|
|
)
|
|
|
|
assert link.asdict()["link_style"] == {
|
|
"color": "#00ff00",
|
|
"width": 3,
|
|
"type": 1,
|
|
"link_type": "flowchart",
|
|
"bezier_curviness": 150,
|
|
"flowchart_roundness": 20,
|
|
}
|
|
link._project.emit_notification.assert_called_with("link.updated", link.asdict())
|
|
assert project.dump.called
|