YueGuobin
de986e890e
feat: name nodes and templates in Docker image delete conflicts
...
The compute translates the container ids in a daemon delete conflict
into the GNS3 node and project behind each container. Leftover
containers from closed projects and containers created outside GNS3
are named as such.
The controller lists the templates referencing the image in the
conflict error, matched through the canonical image name. After a
successful deletion it emits a docker.image.deleted notification with
those templates: their nodes can no longer start.
2026-11-06 22:05:52 +08:00
YueGuobin
04a8ba06a8
fix: start pull events when the pull begins and reject unsafe image names
...
The pull started event was emitted by the route before the pull took
its per compute lock, so a request queued behind another pull claimed
to be running while it was still waiting. The pull now reports the
started state itself, once it owns the lock.
Deleting an image interpolates the name into the daemon API path. The
pattern on the path parameter limits it to the characters of an image
reference and validate_docker_image_name also rejects "..", so a name
cannot escape that path. Applied on both the controller and compute
routes.
2026-11-06 15:42:51 +08:00
grossmj
110638d81a
refactor: replace os.path.commonprefix with os.path.commonpath for path comparisons
2026-10-31 19:43:52 +07:00
Cristi
84b4c05b9f
feat(qemu): support two CD/DVD images and consistent ISO handling
2026-10-17 23:08:11 +03:00
Jeremy Grossmann
f184883aa7
Merge branch '3.1' into images-nested-folders-support
2026-10-06 16:50:40 +02:00
Cristi
5492105e58
fix(image-manager): Fix type-check errors in image uploads and appliance installation
2026-10-06 00:13:53 +03:00
Cristi
207db770c6
feat(image-manager): Add support for nested image folders and appliance compatibility checks
2026-10-05 18:49:21 +03:00
Mark Paronyan
3135c8b7e3
refactor: use f-strings in remaining modules, scripts and tests
2026-10-03 19:44:02 +03:00
Mark Paronyan
634189d443
style: sort imports in api and utils modules
2026-10-02 12:43:26 +03:00
Mark Paronyan
a77e06b907
Merge branch '3.1' into ruff/trivia-fixups
2026-10-01 19:58:02 +03:00
Mark Paronyan
2dc7479d11
style: remove f-strings without placeholders
2026-10-01 19:57:46 +03:00
Mark Paronyan
7a1e79a8a0
style: parenthesize chained boolean operators
2026-10-01 19:57:43 +03:00
Mark Paronyan
c5b5091f5e
refactor: use explicit conversion in f-strings
2026-10-01 19:57:41 +03:00
grossmj
1456d36bf0
chore(tests): fix mypy errors
2026-10-01 15:22:17 +02:00
Jeremy Grossmann
a2cdc14a25
Merge branch '3.1' into image-manager-out-of-sync
2026-10-01 14:44:24 +02:00
Cristi
87df09c00c
fix(images): Fix symlinked image imports and add regression tests
2026-09-29 20:16:22 +03:00
Mark Paronyan
ab5572a0c1
fix(typing): resolve mypy errors in utils.images
2026-09-29 08:48:06 +03:00
Cristi
42d30651da
Merge origin/3.1 into image-manager-out-of-sync
...
Preserve image reconciliation, locking, and regression coverage while integrating upstream release, dependency, typing, and formatting updates. Align feature code with the new Ruff checks.
2026-09-28 23:16:24 +03:00
Cristi
046dff4d08
fix(images): reconcile the image inventory with filesystem changes
2026-09-28 16:01:36 +03:00
Mark Paronyan
a0450b6bce
refactor: ruff autofixes
2026-09-27 15:55:10 +03:00
YueGuobin
3465c39eaa
Reduce md5sum cache write failure log level from error to warning
...
This is a non-fatal issue that occurs during concurrent project close
when multiple nodes try to write their md5sum cache while the project
directory is being cleaned up.
2026-06-15 13:27:14 +08:00
grossmj
4606613673
Fix image handling
2026-03-05 12:38:28 +08:00
grossmj
8b245c96f8
Qemu VMs: only compute MD5 checksums for existing disks
2026-03-04 18:54:52 +08:00
grossmj
aa8ccf4f82
Allow an image to be uploaded to the controller again even if it is already in the database
2025-04-17 19:07:22 +07:00
grossmj
4758431c76
Improvements for built-in disks
...
* Checksum is updated in the database for updated disks.
* It is not possible to prune them.
2025-01-02 23:10:51 +07:00
grossmj
bbff6974e6
Fix undefined name 'default_directory'
2024-12-02 14:36:58 +10:00
grossmj
c05dcef54f
Fix formatting issue
2024-12-02 13:18:12 +10:00
grossmj
b7d43b29cd
Fix tests after merging
2024-12-02 13:02:08 +10:00
grossmj
cbaa563996
Merge branch '2.2' into 3.0
...
# Conflicts:
# CHANGELOG
# gns3server/crash_report.py
# gns3server/static/web-ui/index.html
# gns3server/static/web-ui/main.9297104511b6616fc55c.js
# gns3server/utils/images.py
# gns3server/version.py
# tests/api/routes/compute/test_dynamips_nodes.py
# tests/handlers/api/compute/test_qemu.py
# tests/utils/test_images.py
2024-12-02 12:16:34 +10:00
grossmj
19cabdfde6
Use log.debug for some messages in images.py
2024-11-28 12:42:50 +10:00
grossmj
3d58b437b4
Remove restrictions based on file extension when listing images and fix ELF header checks
2024-11-27 14:51:34 +10:00
grossmj
d3860ba84b
Merge branch '2.2' into 3.0
...
# Conflicts:
# CHANGELOG
# dev-requirements.txt
# gns3server/compute/qemu/__init__.py
# gns3server/compute/vmware/__init__.py
# gns3server/controller/snapshot.py
# gns3server/crash_report.py
# gns3server/handlers/api/compute/atm_switch_handler.py
# gns3server/run.py
# gns3server/static/web-ui/26.77d4bfd104f37c42e028.js
# gns3server/static/web-ui/index.html
# gns3server/static/web-ui/runtime.415291667f70565cd8ef.js
# gns3server/utils/__init__.py
# gns3server/utils/images.py
# gns3server/utils/interfaces.py
# gns3server/version.py
# gns3server/web/web_server.py
# pytest.ini
# requirements.txt
# scripts/update-bundled-web-ui.sh
# setup.py
# tests/api/routes/compute/test_dynamips_nodes.py
# tests/compute/builtin/nodes/test_cloud.py
# tests/compute/docker/test_docker.py
# tests/compute/docker/test_docker_vm.py
# tests/compute/dynamips/test_dynamips_manager.py
# tests/compute/dynamips/test_dynamips_router.py
# tests/compute/iou/test_iou_vm.py
# tests/compute/qemu/test_qcow2.py
# tests/compute/qemu/test_qemu_manager.py
# tests/compute/qemu/test_qemu_vm.py
# tests/compute/test_base_node.py
# tests/compute/test_manager.py
# tests/compute/test_project.py
# tests/compute/traceng/test_traceng_vm.py
# tests/compute/virtualbox/test_virtualbox_manager.py
# tests/compute/virtualbox/test_virtualbox_vm.py
# tests/compute/vmware/test_vmware_manager.py
# tests/compute/vmware/test_vmware_vm.py
# tests/compute/vpcs/test_vpcs_vm.py
# tests/conftest.py
# tests/controller/gns3vm/test_remote_gns3_vm.py
# tests/controller/gns3vm/test_virtualbox_gns3_vm.py
# tests/controller/gns3vm/test_vmware_gns3_vm.py
# tests/controller/test_export_project.py
# tests/controller/test_gns3vm.py
# tests/controller/test_import_project.py
# tests/test_config.py
# tests/utils/test_asyncio.py
# tests/utils/test_images.py
# tests/web/test_response.py
2024-05-16 17:53:39 +07:00
grossmj
3df7af12e1
Allow listing x86_64 IOU images. Fixes #2376
2024-05-09 15:21:05 +07:00
grossmj
fe90d2b146
Merge branch '2.2' into 3.0
...
# Conflicts:
# gns3server/controller/__init__.py
# gns3server/controller/appliance_manager.py
# gns3server/crash_report.py
# gns3server/run.py
# gns3server/static/web-ui/index.html
# gns3server/utils/images.py
# gns3server/version.py
# requirements.txt
# scripts/update-bundled-web-ui.sh
2023-08-10 15:00:22 +10:00
grossmj
7ef9b7600c
Use DEFAULT_BUFFER_SIZE for md5sum
2023-08-03 12:09:24 +10:00
grossmj
1d59afa9fb
Merge branch '2.2' into 3.0
...
# Conflicts:
# gns3server/controller/__init__.py
# gns3server/crash_report.py
# gns3server/handlers/api/controller/node_handler.py
# gns3server/utils/images.py
2023-08-02 18:26:50 +10:00
grossmj
af83adfdf6
Add debug message when calculating MD5 checksum
2023-08-02 17:41:51 +10:00
grossmj
161f62d083
Install empty Qemu disks on first start
2023-05-05 22:40:58 +08:00
grossmj
c6e31d98db
Option to disable image discovery and do not scan parent directory
2022-12-26 12:32:40 +08:00
grossmj
725942157e
Optionally allow Qemu raw images
2022-07-22 12:39:52 +02:00
grossmj
30f7c0ce74
Fix issues when discovering images
2022-06-03 15:35:33 +07:00
grossmj
89c67790ae
Make sure that the temporary image file is removed after uploading an image
2022-04-27 16:00:02 +07:00
grossmj
3106c8a6a2
Do not cache to md5sum file in some situations
2022-04-18 17:13:52 +07:00
grossmj
e6c8144210
Detect new images added to the default image directory.
...
* Images can be present before the server starts or while it is running
* Images are recorded in the database
2022-04-17 16:58:20 +07:00
grossmj
e50bed5bee
Support delete Qemu disk image from API
...
Return the real disk image name in the 'hdx_disk_image_backed' property for Qemu VMs
2022-04-14 17:01:54 +07:00
grossmj
9b39bfb845
Detect image type instead of requesting it from user
2022-03-20 16:20:17 +10:00
grossmj
bc36d95060
Finalize image management refactoring and auto install appliance if possible
2021-10-10 17:35:11 +10:30
grossmj
d606553e20
Allow images to be stored in subdirs and used by templates.
2021-08-30 16:53:41 +09:30
grossmj
078c42f185
Save image size + start to automatic template creation based on image checksum.
2021-08-11 16:58:23 +09:30
grossmj
515bd50261
Start refactoring for images management
2021-06-06 16:52:47 +09:30