VPCS is trully async

tests/api/test_vpcs.py

@@ -84,3 +84,13 @@ def test_vpcs_delete_nio(server, vm):
     response = server.delete("/vpcs/{}/ports/0/nio".format(vm["uuid"]), example=True)
     assert response.status == 200
     assert response.route == "/vpcs/{uuid}/ports/{port_id}/nio"
+
+
+def test_vpcs_start():
+    # assert True == False
+    pass
+
+
+def test_vpcs_stop():
+    # assert True == False
+    pass

tests/modules/vpcs/test_vpcs_vm.py

@@ -36,20 +36,19 @@ def manager():
     return m
 
 
-@patch("subprocess.check_output", return_value="Welcome to Virtual PC Simulator, version 0.6".encode("utf-8"))
 def test_vm(project, manager):
     vm = VPCSVM("test", "00010203-0405-0607-0809-0a0b0c0d0e0f", project, manager)
     assert vm.name == "test"
     assert vm.uuid == "00010203-0405-0607-0809-0a0b0c0d0e0f"
 
 
-@patch("subprocess.check_output", return_value="Welcome to Virtual PC Simulator, version 0.1".encode("utf-8"))
 def test_vm_invalid_vpcs_version(project, manager, loop):
-    with pytest.raises(VPCSError):
-        vm = VPCSVM("test", "00010203-0405-0607-0809-0a0b0c0d0e0f", project, manager)
-        loop.run_until_complete(asyncio.async(vm.start()))
-        assert vm.name == "test"
-        assert vm.uuid == "00010203-0405-0607-0809-0a0b0c0d0e0f"
+    with asyncio_patch("gns3server.modules.vpcs.vpcs_vm.VPCSVM._get_vpcs_welcome", return_value="Welcome to Virtual PC Simulator, version 0.1"):
+        with pytest.raises(VPCSError):
+            vm = VPCSVM("test", "00010203-0405-0607-0809-0a0b0c0d0e0f", project, manager)
+            loop.run_until_complete(asyncio.async(vm.start()))
+            assert vm.name == "test"
+            assert vm.uuid == "00010203-0405-0607-0809-0a0b0c0d0e0f"
 
 
 @patch("gns3server.config.Config.get_section_config", return_value={"path": "/bin/test_fake"})
@@ -61,28 +60,28 @@ def test_vm_invalid_vpcs_path(project, manager, loop):
         assert vm.uuid == "00010203-0405-0607-0809-0a0b0c0d0e0f"
 
 
-@patch("gns3server.modules.vpcs.vpcs_vm.VPCSVM._check_requirements", return_value=True)
 def test_start(project, loop, manager):
-    with asyncio_patch("asyncio.create_subprocess_exec", return_value=MagicMock()):
-        vm = VPCSVM("test", "00010203-0405-0607-0809-0a0b0c0d0e0f", project, manager)
-        nio = vm.port_add_nio_binding(0, {"type": "nio_udp", "lport": 4242, "rport": 4243, "rhost": "127.0.0.1"})
+    with asyncio_patch("gns3server.modules.vpcs.vpcs_vm.VPCSVM._check_requirements", return_value=True):
+        with asyncio_patch("asyncio.create_subprocess_exec", return_value=MagicMock()):
+            vm = VPCSVM("test", "00010203-0405-0607-0809-0a0b0c0d0e0f", project, manager)
+            nio = vm.port_add_nio_binding(0, {"type": "nio_udp", "lport": 4242, "rport": 4243, "rhost": "127.0.0.1"})
 
-        loop.run_until_complete(asyncio.async(vm.start()))
-        assert vm.is_running()
+            loop.run_until_complete(asyncio.async(vm.start()))
+            assert vm.is_running()
 
 
-@patch("gns3server.modules.vpcs.vpcs_vm.VPCSVM._check_requirements", return_value=True)
 def test_stop(project, loop, manager):
     process = MagicMock()
-    with asyncio_patch("asyncio.create_subprocess_exec", return_value=process):
-        vm = VPCSVM("test", "00010203-0405-0607-0809-0a0b0c0d0e0f", project, manager)
-        nio = vm.port_add_nio_binding(0, {"type": "nio_udp", "lport": 4242, "rport": 4243, "rhost": "127.0.0.1"})
+    with asyncio_patch("gns3server.modules.vpcs.vpcs_vm.VPCSVM._check_requirements", return_value=True):
+        with asyncio_patch("asyncio.create_subprocess_exec", return_value=process):
+            vm = VPCSVM("test", "00010203-0405-0607-0809-0a0b0c0d0e0f", project, manager)
+            nio = vm.port_add_nio_binding(0, {"type": "nio_udp", "lport": 4242, "rport": 4243, "rhost": "127.0.0.1"})
 
-        loop.run_until_complete(asyncio.async(vm.start()))
-        assert vm.is_running()
-        loop.run_until_complete(asyncio.async(vm.stop()))
-        assert vm.is_running() is False
-        process.terminate.assert_called_with()
+            loop.run_until_complete(asyncio.async(vm.start()))
+            assert vm.is_running()
+            loop.run_until_complete(asyncio.async(vm.stop()))
+            assert vm.is_running() is False
+            process.terminate.assert_called_with()
 
 
 def test_add_nio_binding_udp(manager, project):