fix: commit the bulk ACE deletion in the repository

delete_all_ace_starting_with_path was the only RBAC write method
without a commit. The request session is only closed at teardown, so
the deletion was rolled back and the ACEs came back on the next
snapshot reload. Tests did not catch it because they share one
session for the whole class.
This commit is contained in:
YueGuobin committed 2026-11-06 23:55:12 +08:00
1 parent 2244d730bb
commit f87f20cb27
2 files changed
+22

No files matched your search

+21
View File
@@ -146,6 +146,27 @@ class TestPrivileges:
authorized = await RbacRepository(db_session).check_user_has_privilege(test_user.user_id, path, privilege)
assert authorized is True
async def test_delete_all_ace_starting_with_path_is_committed(self, db_session: AsyncSession):
"""
Production requests get a fresh session that is only closed at
teardown, rolling back uncommitted work: the bulk ACE deletion must
be committed to survive the end of the request.
"""
rbac_repo = RbacRepository(db_session)
group_id = (await UsersRepository(db_session).get_user_group_by_name("Users")).user_group_id
role_id = (await rbac_repo.get_role_by_name("User")).role_id
path = f"/projects/{uuid.uuid4()}"
await rbac_repo.create_ace(
ACECreate(path=path, ace_type="group", propagate=False, group_id=str(group_id), role_id=str(role_id))
)
await rbac_repo.delete_all_ace_starting_with_path(path)
# simulate the production session teardown: close() rolls back the
# open transaction and an uncommitted deletion would be lost
await db_session.rollback()
assert await rbac_repo.check_ace_exists(path) is False
class TestResourcePools:
async def test_resource_pool(self, test_user: User, db_session: AsyncSession):