From f3aaa902c6d1366b02e6898f258e3cb98a8c5481 Mon Sep 17 00:00:00 2001 From: YueGuobin Date: Mon, 1 Jun 2026 12:46:15 +0800 Subject: [PATCH] Fix double deletion issue in remove_resource_from_pool Remove duplicate delete_resource call from remove_resource_from_pool since the API layer already handles resource deletion. This prevents conflicts where the API layer tries to delete a resource that was already deleted by the repository layer. The complete fix is now: - remove_resource_from_pool: Only removes resource from pool (API handles deletion) - delete_resource_pool: Deletes all resource records before deleting pool --- gns3server/db/repositories/pools.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/gns3server/db/repositories/pools.py b/gns3server/db/repositories/pools.py index b5d81c607..336c29c8d 100644 --- a/gns3server/db/repositories/pools.py +++ b/gns3server/db/repositories/pools.py @@ -212,8 +212,6 @@ class ResourcePoolsRepository(BaseRepository): await self._db_session.commit() await self._db_session.refresh(resource_pool_db) - await self.delete_resource(resource.resource_id) - return resource_pool_db async def get_pool_resources(self, resource_pool_id: UUID) -> List[models.Resource]: