Prevent corruption of VM in VirtualBox when using linked clone

Fix https://github.com/GNS3/gns3-gui/issues/1821
This commit is contained in:
Julien Duponchelle committed 2017-01-31 18:58:43 +01:00
1 parent 27a1089806
commit f0ff035c0b
4 files changed
+37 -10

No files matched your search

@@ -603,9 +603,16 @@ class VirtualBoxVM(BaseNode):
:param vmname: VirtualBox VM name
"""
if vmname == self._vmname:
return
if self.linked_clone:
if self.status == "started":
raise VirtualBoxError("You can't change the name of running VM {}".format(self._name))
# We can't rename a VM to name that already exists
vms = yield from self.manager.list_vms(allow_clone=True)
if vmname in [vm["vmname"] for vm in vms]:
raise VirtualBoxError("You can't change the name to {} it's already use in VirtualBox".format(vmname))
yield from self._modify_vm('--name "{}"'.format(vmname))
log.info("VirtualBox VM '{name}' [{id}] has set the VM name to '{vmname}'".format(name=self.name, id=self.id, vmname=vmname))