From e6053dd0a8b4c9c377bab0081b4091761c2c8823 Mon Sep 17 00:00:00 2001 From: Mark Paronyan Date: Mon, 28 Sep 2026 05:10:23 +0000 Subject: [PATCH] fix(typing): resolve mypy errors in services.computes --- gns3server/db/repositories/computes.py | 10 ++++++---- pyproject.toml | 1 - 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/gns3server/db/repositories/computes.py b/gns3server/db/repositories/computes.py index 4f3aac7f4..5747fbf03 100644 --- a/gns3server/db/repositories/computes.py +++ b/gns3server/db/repositories/computes.py @@ -16,7 +16,7 @@ # along with this program. If not, see . from uuid import UUID -from typing import Optional, List +from typing import Optional, List, Union from sqlalchemy import select, update, delete from sqlalchemy.ext.asyncio import AsyncSession @@ -31,7 +31,7 @@ class ComputesRepository(BaseRepository): super().__init__(db_session) - async def get_compute(self, compute_id: UUID) -> Optional[models.Compute]: + async def get_compute(self, compute_id: Union[str, UUID]) -> Optional[models.Compute]: query = select(models.Compute).where(models.Compute.compute_id == compute_id) result = await self._db_session.execute(query) @@ -65,7 +65,9 @@ class ComputesRepository(BaseRepository): await self._db_session.refresh(db_compute) return db_compute - async def update_compute(self, compute_id: UUID, compute_update: schemas.ComputeUpdate) -> Optional[models.Compute]: + async def update_compute( + self, compute_id: Union[str, UUID], compute_update: schemas.ComputeUpdate + ) -> Optional[models.Compute]: update_values = compute_update.model_dump(exclude_unset=True) if compute_update.password is not None: @@ -80,7 +82,7 @@ class ComputesRepository(BaseRepository): await self._db_session.refresh(compute_db) # force refresh of updated_at value return compute_db - async def delete_compute(self, compute_id: UUID) -> bool: + async def delete_compute(self, compute_id: Union[str, UUID]) -> bool: query = delete(models.Compute).where(models.Compute.compute_id == compute_id) result = await self._db_session.execute(query) diff --git a/pyproject.toml b/pyproject.toml index a9780d39c..1179d2526 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -391,7 +391,6 @@ module = [ "gns3server.schemas.controller.projects", # 2 "gns3server.schemas.controller.settings", # 3 "gns3server.schemas.controller.templates.docker_templates", # 1 - "gns3server.services.computes", # 4 "gns3server.services.templates", # 18 "gns3server.utils.asyncio.aiozipstream", # 8 "gns3server.utils.encryption", # 2