NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-10-23 03:12:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

feat(api): fix ETag handling and JSON serialization in template endpoint

Browse Source 
- Use `default=str` in `json.dumps` to handle non-serializable objects
- Return proper HTTP 304 response with ETag header instead of raising exception
- Ensure consistent ETag generation for template caching
This commit is contained in:
YueGuobin 2026-02-22 23:43:47 +08:00
parent a3616e6d33
commit e27ddf2cdf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gns3server/api/routes/controller/templates.py
View File

@ -88,10 +88,10 @@ async def get_template(
request_etag = request.headers.get("If-None-Match", "") request_etag = request.headers.get("If-None-Match", "")
template = await TemplatesService(templates_repo).get_template(template_id) template = await TemplatesService(templates_repo).get_template(template_id)
data = json.dumps(template) data = json.dumps(template, default=str)
template_etag = '"' + hashlib.md5(data.encode()).hexdigest() + '"' template_etag = '"' + hashlib.md5(data.encode()).hexdigest() + '"'
if template_etag == request_etag: if template_etag == request_etag:
raise HTTPException(status_code=status.HTTP_304_NOT_MODIFIED) return Response(status_code=status.HTTP_304_NOT_MODIFIED, headers={"ETag": template_etag})
else: else:
response.headers["ETag"] = template_etag response.headers["ETag"] = template_etag
return template return template