From e1f25ce63b036424ff94c89cd508cbe71d6ed65f Mon Sep 17 00:00:00 2001 From: YueGuobin Date: Tue, 17 Mar 2026 22:06:53 +0800 Subject: [PATCH] fix(tests): replace assertIs with assertEqual in custom netmiko tests Changed test assertions from `assertIs` to `assertEqual` for class mapper comparisons in Huawei CE, Ruijie, and VPCS telnet driver tests. This ensures proper equality checking rather than identity checking, which is more appropriate for class comparisons in these test cases. --- .../gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py | 4 ++-- .../utils/custom_netmiko/tests/test_ruijie_telnet.py | 4 ++-- .../utils/custom_netmiko/tests/test_vpcs_telnet.py | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py index a5a06157b..62a1c3a5c 100644 --- a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py +++ b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py @@ -51,14 +51,14 @@ class TestHuaweiTelnetCEDriver(unittest.TestCase): # Check CLASS_MAPPER self.assertIn("gns3_huawei_telnet_ce", CLASS_MAPPER) - self.assertIs( + self.assertEqual( CLASS_MAPPER["gns3_huawei_telnet_ce"], self.HuaweiTelnetCE ) # Check CLASS_MAPPER_BASE self.assertIn("gns3_huawei_telnet_ce", CLASS_MAPPER_BASE) - self.assertIs( + self.assertEqual( CLASS_MAPPER_BASE["gns3_huawei_telnet_ce"], self.HuaweiTelnetCE ) diff --git a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py index 4fe72b21a..682050c9e 100644 --- a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py +++ b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py @@ -51,14 +51,14 @@ class TestRuijieTelnetEnhancedDriver(unittest.TestCase): # Check CLASS_MAPPER self.assertIn("gns3_ruijie_telnet", CLASS_MAPPER) - self.assertIs( + self.assertEqual( CLASS_MAPPER["gns3_ruijie_telnet"], self.RuijieTelnetEnhanced ) # Check CLASS_MAPPER_BASE self.assertIn("gns3_ruijie_telnet", CLASS_MAPPER_BASE) - self.assertIs( + self.assertEqual( CLASS_MAPPER_BASE["gns3_ruijie_telnet"], self.RuijieTelnetEnhanced ) diff --git a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py index 1b4eb9b4f..64700e139 100644 --- a/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py +++ b/gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py @@ -53,14 +53,14 @@ class TestVPCSTelnetDriver(unittest.TestCase): # Check CLASS_MAPPER self.assertIn("gns3_vpcs_telnet", CLASS_MAPPER) - self.assertIs( + self.assertEqual( CLASS_MAPPER["gns3_vpcs_telnet"], self.VPCSTelnet ) # Check CLASS_MAPPER_BASE self.assertIn("gns3_vpcs_telnet", CLASS_MAPPER_BASE) - self.assertIs( + self.assertEqual( CLASS_MAPPER_BASE["gns3_vpcs_telnet"], self.VPCSTelnet )