NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-10-28 11:12:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2713 from yueguobin/fix/docker-container-deletion-error-handling

Browse Source 
Fix: Improve Docker container deletion error logging
This commit is contained in:
Jeremy Grossmann 2026-05-07 22:17:23 +08:00 committed by GitHub
commit e0860555ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gns3server/compute/docker/docker_vm.py
View File

@ -1089,8 +1089,13 @@ class DockerVM(BaseNode):
# force - 1/True/true or 0/False/false, Kill then remove the container. Default false. # force - 1/True/true or 0/False/false, Kill then remove the container. Default false.
try: try:
await self.manager.query("DELETE", f"containers/{self._cid}", params={"force": 1, "v": 1}) await self.manager.query("DELETE", f"containers/{self._cid}", params={"force": 1, "v": 1})
except DockerError: except DockerHttp404Error:
# Container already removed (normal case)
pass pass
except DockerError as e:
# Container deletion failed - log warning but don't block project close
# The stale container will be cleaned up when the project is opened again
log.warning(f"Failed to delete Docker container '{self.docker_name}': {e}")
log.info("Docker container '{name}' [{image}] removed".format(name=self._name, image=self._image)) log.info("Docker container '{name}' [{image}] removed".format(name=self._name, image=self._image))
if release_nio_udp_ports: if release_nio_udp_ports: