NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-10-25 11:22:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve MCP server URL host via default route IP when bound to 0.0.0.0

Browse Source 
When GNS3 server is configured to listen on 0.0.0.0 (all interfaces),
_server_url() was hardcoding 127.0.0.1, making the WebSocket console
URL unreachable from remote MCP clients.

Use the UDP connect trick (connect to 8.8.8.8:80 without sending data)
to discover the default route interface IP, which is the address remote
clients can actually reach.
This commit is contained in:
YueGuobin 2026-06-06 00:48:22 +08:00
parent 4d87b57f18
commit db9772ca7a
No known key found for this signature in database
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gns3server/api/routes/mcp/__init__.py
View File

@ -30,6 +30,7 @@ import contextvars
import json import json
import asyncio import asyncio
import logging import logging
import socket
from typing import Any, Annotated from typing import Any, Annotated
from urllib.parse import parse_qs from urllib.parse import parse_qs
@ -94,8 +95,14 @@ async def _validate_token(token: str) -> bool:
def _server_url() -> str: def _server_url() -> str:
cfg = Config.instance().settings cfg = Config.instance().settings
host = cfg.Server.host host = cfg.Server.host
if host == "0.0.0.0": if host in ("0.0.0.0", "::"):
host = "127.0.0.1" try:
with socket.socket(socket.AF_INET, socket.SOCK_DGRAM) as s:
s.settimeout(0.1)
s.connect(("8.8.8.8", 80))
host = s.getsockname()[0]
except OSError:
host = "127.0.0.1"
scheme = "https" if cfg.Server.enable_ssl else "http" scheme = "https" if cfg.Server.enable_ssl else "http"
return f"{scheme}://{host}:{cfg.Server.port}" return f"{scheme}://{host}:{cfg.Server.port}"