mirror of
https://github.com/GNS3/gns3-server.git
synced 2026-11-20 21:25:14 +02:00
Refactor tests
* Use pytest-aiohttp * Use the async def / await syntax. * Fix tests to run with Python 3.8
This commit is contained in:
1 parent
f498ab06b4
commit
d3ea67da24
87 files changed
+3697
-3528
No files matched your search
@@ -1,6 +1,6 @@
|
||||
#!/usr/bin/env python
|
||||
#
|
||||
# Copyright (C) 2016 GNS3 Technologies Inc.
|
||||
# Copyright (C) 2020 GNS3 Technologies Inc.
|
||||
#
|
||||
# This program is free software: you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
@@ -15,35 +15,20 @@
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
import os
|
||||
import pytest
|
||||
import aiohttp
|
||||
import asyncio
|
||||
from unittest.mock import MagicMock
|
||||
|
||||
|
||||
from gns3server.controller.link import Link
|
||||
from gns3server.controller.node import Node
|
||||
from gns3server.controller.ports.ethernet_port import EthernetPort
|
||||
from gns3server.controller.ports.serial_port import SerialPort
|
||||
from gns3server.controller.compute import Compute
|
||||
from gns3server.controller.project import Project
|
||||
|
||||
from tests.utils import AsyncioBytesIO, AsyncioMagicMock
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def project(controller):
|
||||
return Project(controller=controller, name="Test")
|
||||
async def link(project, compute):
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def compute():
|
||||
return Compute("example.com", controller=MagicMock())
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def link(async_run, project, compute):
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
node2 = Node(project, compute, "node2", node_type="qemu")
|
||||
@@ -51,26 +36,27 @@ def link(async_run, project, compute):
|
||||
|
||||
link = Link(project)
|
||||
link.create = AsyncioMagicMock()
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
async_run(link.add_node(node2, 1, 3))
|
||||
await link.add_node(node1, 0, 4)
|
||||
await link.add_node(node2, 1, 3)
|
||||
return link
|
||||
|
||||
|
||||
def test_eq(project, link, controller):
|
||||
def test_eq(project, link):
|
||||
|
||||
assert link == Link(project, link_id=link.id)
|
||||
assert link != "a"
|
||||
assert link != Link(project)
|
||||
|
||||
|
||||
def test_add_node(async_run, project, compute):
|
||||
async def test_add_node(project, compute):
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
|
||||
link = Link(project)
|
||||
link.create = AsyncioMagicMock()
|
||||
link._project.emit_notification = MagicMock()
|
||||
project.dump = AsyncioMagicMock()
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
assert link._nodes == [
|
||||
{
|
||||
"node": node1,
|
||||
@@ -85,23 +71,23 @@ def test_add_node(async_run, project, compute):
|
||||
]
|
||||
assert project.dump.called
|
||||
assert not link._project.emit_notification.called
|
||||
|
||||
assert not link.create.called
|
||||
|
||||
# We call link.created only when both side are created
|
||||
node2 = Node(project, compute, "node2", node_type="qemu")
|
||||
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
async_run(link.add_node(node2, 0, 4))
|
||||
await link.add_node(node2, 0, 4)
|
||||
|
||||
assert link.create.called
|
||||
link._project.emit_notification.assert_called_with("link.created", link.__json__())
|
||||
assert link in node2.links
|
||||
|
||||
|
||||
def test_add_node_already_connected(async_run, project, compute):
|
||||
async def test_add_node_already_connected(project, compute):
|
||||
"""
|
||||
Raise an error if we try to use an already connected port
|
||||
"""
|
||||
|
||||
project.dump = AsyncioMagicMock()
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
@@ -110,19 +96,20 @@ def test_add_node_already_connected(async_run, project, compute):
|
||||
link = Link(project)
|
||||
link.create = AsyncioMagicMock()
|
||||
link._project.emit_notification = MagicMock()
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
node2 = Node(project, compute, "node2", node_type="qemu")
|
||||
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
async_run(link.add_node(node2, 0, 4))
|
||||
await link.add_node(node2, 0, 4)
|
||||
|
||||
assert link.create.called
|
||||
link2 = Link(project)
|
||||
link2.create = AsyncioMagicMock()
|
||||
with pytest.raises(aiohttp.web.HTTPConflict):
|
||||
async_run(link2.add_node(node1, 0, 4))
|
||||
await link2.add_node(node1, 0, 4)
|
||||
|
||||
|
||||
def test_add_node_cloud(async_run, project, compute):
|
||||
async def test_add_node_cloud(project, compute):
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
node2 = Node(project, compute, "node2", node_type="cloud")
|
||||
@@ -132,14 +119,15 @@ def test_add_node_cloud(async_run, project, compute):
|
||||
link.create = AsyncioMagicMock()
|
||||
link._project.emit_notification = MagicMock()
|
||||
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
async_run(link.add_node(node2, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
await link.add_node(node2, 0, 4)
|
||||
|
||||
|
||||
def test_add_node_cloud_to_cloud(async_run, project, compute):
|
||||
async def test_add_node_cloud_to_cloud(project, compute):
|
||||
"""
|
||||
Cloud to cloud connection is not allowed
|
||||
"""
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="cloud")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
node2 = Node(project, compute, "node2", node_type="cloud")
|
||||
@@ -149,15 +137,16 @@ def test_add_node_cloud_to_cloud(async_run, project, compute):
|
||||
link.create = AsyncioMagicMock()
|
||||
link._project.emit_notification = MagicMock()
|
||||
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
with pytest.raises(aiohttp.web.HTTPConflict):
|
||||
async_run(link.add_node(node2, 0, 4))
|
||||
await link.add_node(node2, 0, 4)
|
||||
|
||||
|
||||
def test_add_node_same_node(async_run, project, compute):
|
||||
async def test_add_node_same_node(project, compute):
|
||||
"""
|
||||
Connection to the same node is not allowed
|
||||
"""
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4), EthernetPort("E1", 0, 0, 5)]
|
||||
|
||||
@@ -165,15 +154,16 @@ def test_add_node_same_node(async_run, project, compute):
|
||||
link.create = AsyncioMagicMock()
|
||||
link._project.emit_notification = MagicMock()
|
||||
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
with pytest.raises(aiohttp.web.HTTPConflict):
|
||||
async_run(link.add_node(node1, 0, 5))
|
||||
await link.add_node(node1, 0, 5)
|
||||
|
||||
|
||||
def test_add_node_serial_to_ethernet(async_run, project, compute):
|
||||
async def test_add_node_serial_to_ethernet(project, compute):
|
||||
"""
|
||||
Serial to ethernet connection is not allowed
|
||||
"""
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
node2 = Node(project, compute, "node2", node_type="qemu")
|
||||
@@ -183,12 +173,13 @@ def test_add_node_serial_to_ethernet(async_run, project, compute):
|
||||
link.create = AsyncioMagicMock()
|
||||
link._project.emit_notification = MagicMock()
|
||||
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
with pytest.raises(aiohttp.web.HTTPConflict):
|
||||
async_run(link.add_node(node2, 0, 4))
|
||||
await link.add_node(node2, 0, 4)
|
||||
|
||||
|
||||
def test_json(async_run, project, compute, link):
|
||||
async def test_json(project, compute):
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
node2 = Node(project, compute, "node2", node_type="qemu")
|
||||
@@ -196,8 +187,8 @@ def test_json(async_run, project, compute, link):
|
||||
|
||||
link = Link(project)
|
||||
link.create = AsyncioMagicMock()
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
async_run(link.add_node(node2, 1, 3))
|
||||
await link.add_node(node1, 0, 4)
|
||||
await link.add_node(node2, 1, 3)
|
||||
assert link.__json__() == {
|
||||
"link_id": link.id,
|
||||
"project_id": project.id,
|
||||
@@ -256,7 +247,8 @@ def test_json(async_run, project, compute, link):
|
||||
}
|
||||
|
||||
|
||||
def test_json_serial_link(async_run, project, compute, link):
|
||||
async def test_json_serial_link(project, compute):
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [SerialPort("S0", 0, 0, 4)]
|
||||
node2 = Node(project, compute, "node2", node_type="qemu")
|
||||
@@ -264,11 +256,13 @@ def test_json_serial_link(async_run, project, compute, link):
|
||||
|
||||
link = Link(project)
|
||||
link.create = AsyncioMagicMock()
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
async_run(link.add_node(node2, 1, 3))
|
||||
await link.add_node(node1, 0, 4)
|
||||
await link.add_node(node2, 1, 3)
|
||||
assert link.__json__()["link_type"] == "serial"
|
||||
|
||||
def test_default_capture_file_name(project, compute, async_run):
|
||||
|
||||
async def test_default_capture_file_name(project, compute):
|
||||
|
||||
node1 = Node(project, compute, "Hello@", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
node2 = Node(project, compute, "w0.rld", node_type="qemu")
|
||||
@@ -276,33 +270,35 @@ def test_default_capture_file_name(project, compute, async_run):
|
||||
|
||||
link = Link(project)
|
||||
link.create = AsyncioMagicMock()
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
async_run(link.add_node(node2, 1, 3))
|
||||
await link.add_node(node1, 0, 4)
|
||||
await link.add_node(node2, 1, 3)
|
||||
assert link.default_capture_file_name() == "Hello_0-4_to_w0rld_1-3.pcap"
|
||||
|
||||
|
||||
def test_start_capture(link, async_run, tmpdir):
|
||||
async def test_start_capture(link):
|
||||
|
||||
async def fake_reader():
|
||||
return AsyncioBytesIO()
|
||||
|
||||
link.read_pcap_from_source = fake_reader
|
||||
link._project.emit_notification = MagicMock()
|
||||
async_run(link.start_capture(capture_file_name="test.pcap"))
|
||||
await link.start_capture(capture_file_name="test.pcap")
|
||||
assert link._capturing
|
||||
assert link._capture_file_name == "test.pcap"
|
||||
link._project.emit_notification.assert_called_with("link.updated", link.__json__())
|
||||
|
||||
|
||||
def test_stop_capture(link, async_run, tmpdir):
|
||||
async def test_stop_capture(link):
|
||||
|
||||
link._capturing = True
|
||||
link._project.emit_notification = MagicMock()
|
||||
async_run(link.stop_capture())
|
||||
await link.stop_capture()
|
||||
assert link._capturing is False
|
||||
link._project.emit_notification.assert_called_with("link.updated", link.__json__())
|
||||
|
||||
|
||||
def test_delete(async_run, project, compute):
|
||||
async def test_delete(project, compute):
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
|
||||
@@ -310,19 +306,18 @@ def test_delete(async_run, project, compute):
|
||||
link.create = AsyncioMagicMock()
|
||||
link._project.emit_notification = MagicMock()
|
||||
project.dump = AsyncioMagicMock()
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
|
||||
node2 = Node(project, compute, "node2", node_type="qemu")
|
||||
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
async_run(link.add_node(node2, 0, 4))
|
||||
|
||||
await link.add_node(node2, 0, 4)
|
||||
assert link in node2.links
|
||||
|
||||
async_run(link.delete())
|
||||
await link.delete()
|
||||
assert link not in node2.links
|
||||
|
||||
|
||||
def test_update_filters(async_run, project, compute):
|
||||
async def test_update_filters(project, compute):
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="qemu")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
|
||||
@@ -330,20 +325,20 @@ def test_update_filters(async_run, project, compute):
|
||||
link.create = AsyncioMagicMock()
|
||||
link._project.emit_notification = MagicMock()
|
||||
project.dump = AsyncioMagicMock()
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
|
||||
node2 = Node(project, compute, "node2", node_type="qemu")
|
||||
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
async_run(link.add_node(node2, 0, 4))
|
||||
await link.add_node(node2, 0, 4)
|
||||
|
||||
link.update = AsyncioMagicMock()
|
||||
assert link._created
|
||||
async_run(link.update_filters({
|
||||
await link.update_filters({
|
||||
"packet_loss": [10],
|
||||
"delay": [50, 10],
|
||||
"frequency_drop": [0],
|
||||
"bpf": [" \n "]
|
||||
}))
|
||||
})
|
||||
assert link.filters == {
|
||||
"packet_loss": [10],
|
||||
"delay": [50, 10]
|
||||
@@ -351,7 +346,8 @@ def test_update_filters(async_run, project, compute):
|
||||
assert link.update.called
|
||||
|
||||
|
||||
def test_available_filters(async_run, project, compute):
|
||||
async def test_available_filters(project, compute):
|
||||
|
||||
node1 = Node(project, compute, "node1", node_type="ethernet_switch")
|
||||
node1._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
|
||||
@@ -360,10 +356,10 @@ def test_available_filters(async_run, project, compute):
|
||||
assert link.available_filters() == []
|
||||
|
||||
# Ethernet switch is not supported should return 0 filters
|
||||
async_run(link.add_node(node1, 0, 4))
|
||||
await link.add_node(node1, 0, 4)
|
||||
assert link.available_filters() == []
|
||||
|
||||
node2 = Node(project, compute, "node2", node_type="vpcs")
|
||||
node2._ports = [EthernetPort("E0", 0, 0, 4)]
|
||||
async_run(link.add_node(node2, 0, 4))
|
||||
await link.add_node(node2, 0, 4)
|
||||
assert len(link.available_filters()) > 0
|
||||
Reference in new issue
Block a user