Refactor tests

* Use pytest-aiohttp
* Use the async def / await syntax.
* Fix tests to run with Python 3.8

tests/compute/virtualbox/test_virtualbox_manager.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 #
-# Copyright (C) 2015 GNS3 Technologies Inc.
+# Copyright (C) 2020 GNS3 Technologies Inc.
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -20,8 +20,6 @@ import pytest
 import tempfile
 import os
 import stat
-import asyncio
-
 
 from unittest.mock import patch
 
@@ -31,19 +29,22 @@ from tests.utils import asyncio_patch
 
 
 @pytest.fixture
-def manager(port_manager):
+async def manager(loop, port_manager):
+
     m = VirtualBox.instance()
     m.port_manager = port_manager
     return m
 
 
 def test_vm_invalid_vboxmanage_path(manager):
+
     with patch("gns3server.config.Config.get_section_config", return_value={"vboxmanage_path": "/bin/test_fake"}):
         with pytest.raises(VirtualBoxError):
             manager.find_vboxmanage()
 
 
 def test_vm_non_executable_vboxmanage_path(manager):
+
     tmpfile = tempfile.NamedTemporaryFile()
     with patch("gns3server.config.Config.get_section_config", return_value={"vboxmanage_path": tmpfile.name}):
         with pytest.raises(VirtualBoxError):
@@ -51,27 +52,28 @@ def test_vm_non_executable_vboxmanage_path(manager):
 
 
 def test_vm_invalid_executable_name_vboxmanage_path(manager, tmpdir):
+
     path = str(tmpdir / "vpcs")
     with open(path, "w+") as f:
         f.write(path)
     os.chmod(path, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
-    tmpfile = tempfile.NamedTemporaryFile()
     with patch("gns3server.config.Config.get_section_config", return_value={"vboxmanage_path": path}):
         with pytest.raises(VirtualBoxError):
             manager.find_vboxmanage()
 
 
 def test_vboxmanage_path(manager, tmpdir):
+
     path = str(tmpdir / "VBoxManage")
     with open(path, "w+") as f:
         f.write(path)
     os.chmod(path, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
-    tmpfile = tempfile.NamedTemporaryFile()
     with patch("gns3server.config.Config.get_section_config", return_value={"vboxmanage_path": path}):
         assert manager.find_vboxmanage() == path
 
 
-def test_list_vms(manager, loop):
+async def test_list_vms(manager):
+
     vm_list = ['"Windows 8.1" {27b4d095-ff5f-4ac4-bb9d-5f2c7861c1f1}',
                '"Carriage',
                'Return" {27b4d095-ff5f-4ac4-bb9d-5f2c7861c3f3}',
@@ -83,7 +85,6 @@ def test_list_vms(manager, loop):
         if cmd == "list":
             return vm_list
         else:
-            print(args)
             if args[0] == "27b4d095-ff5f-4ac4-bb9d-5f2c7861c1f1":
                 return ["memory=512"]
             elif args[0] == "ccd8c50b-c172-457d-99fa-dd69371ede0e":
@@ -92,7 +93,7 @@ def test_list_vms(manager, loop):
 
     with asyncio_patch("gns3server.compute.virtualbox.VirtualBox.execute") as mock:
         mock.side_effect = execute_mock
-        vms = loop.run_until_complete(asyncio.ensure_future(manager.list_vms()))
+        vms = await manager.list_vms()
     assert vms == [
         {"vmname": "Windows 8.1", "ram": 512},
         {"vmname": "Linux Microcore 4.7.1", "ram": 256}