NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-09-15 14:31:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2696 from yueguobin/fix/rfc1123-error-message

Browse Source 
fix: improve hostname validation error messages with allowed characters
This commit is contained in:
Jeremy Grossmann 2026-05-02 18:30:49 +08:00 committed by GitHub
commit b87ab8f86f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gns3server/compute/docker/docker_vm.py
View File

@ -188,7 +188,7 @@ class DockerVM(BaseNode):
""" """
if not is_rfc1123_hostname_valid(new_name): if not is_rfc1123_hostname_valid(new_name):
raise DockerError(f"'{new_name}' is an invalid name to rename Docker container '{self._name}'") raise DockerError(f"'{new_name}' is an invalid name to rename Docker container '{self._name}'. Allowed characters: letters (a-z, A-Z), digits (0-9), and hyphens (-). The name cannot start or end with a hyphen.")
super(DockerVM, DockerVM).name.__set__(self, new_name) super(DockerVM, DockerVM).name.__set__(self, new_name)
@property @property

2
gns3server/compute/dynamips/nodes/router.py
View File

@ -1682,7 +1682,7 @@ class Router(BaseNode):
""" """
if not is_ios_hostname_valid(new_name): if not is_ios_hostname_valid(new_name):
raise DynamipsError(f"{new_name} is an invalid name to rename router '{self._name}'") raise DynamipsError(f"{new_name} is an invalid name to rename router '{self._name}'. Allowed characters: letters (a-z, A-Z), digits (0-9), and hyphens (-). The name must start with a letter, end with a letter or digit, and be 63 characters or fewer.")
await self._hypervisor.send(f'vm rename "{self._name}" "{new_name}"') await self._hypervisor.send(f'vm rename "{self._name}" "{new_name}"')

2
gns3server/compute/iou/iou_vm.py
View File

@ -367,7 +367,7 @@ class IOUVM(BaseNode):
""" """
if not is_ios_hostname_valid(new_name): if not is_ios_hostname_valid(new_name):
raise IOUError(f"'{new_name}' is an invalid name to rename IOU node '{self._name}'") raise IOUError(f"'{new_name}' is an invalid name to rename IOU node '{self._name}'. Allowed characters: letters (a-z, A-Z), digits (0-9), and hyphens (-). The name must start with a letter, end with a letter or digit, and be 63 characters or fewer.")
if self.startup_config_file: if self.startup_config_file:
content = self.startup_config_content content = self.startup_config_content
content = re.sub(r"hostname .+$", "hostname " + new_name, content, flags=re.MULTILINE) content = re.sub(r"hostname .+$", "hostname " + new_name, content, flags=re.MULTILINE)

2
gns3server/compute/qemu/qemu_vm.py
View File

@ -197,7 +197,7 @@ class QemuVM(BaseNode):
""" """
if not is_rfc1123_hostname_valid(new_name): if not is_rfc1123_hostname_valid(new_name):
raise QemuError(f"'{new_name}' is an invalid name to rename Qemu node '{self._name}'") raise QemuError(f"'{new_name}' is an invalid name to rename Qemu node '{self._name}'. Allowed characters: letters (a-z, A-Z), digits (0-9), and hyphens (-). The name cannot start or end with a hyphen.")
super(QemuVM, QemuVM).name.__set__(self, new_name) super(QemuVM, QemuVM).name.__set__(self, new_name)
@property @property