Merge pull request #2663 from cristian-ciobanu/project-monitoring

Enhancement: Refresh projects list without restarting the GNS3 server

gns3server/controller/__init__.py

@@ -22,12 +22,16 @@ import shutil
 import asyncio
 import random
 import json
+import threading
 
 try:
     import importlib_resources
 except ImportError:
     from importlib import resources as importlib_resources
 
+from watchdog.events import FileSystemEventHandler
+from watchdog.observers import Observer
+
 from ..config import Config
 from ..utils import parse_version, md5sum
 from ..utils.images import default_images_directory
@@ -51,6 +55,39 @@ import logging
 log = logging.getLogger(__name__)
 
 
+class _ProjectsDirectoryEventHandler(FileSystemEventHandler):
+    """
+    Watchdog handler for project directory changes.
+    """
+
+    def __init__(self, controller, projects_path):
+        self._controller = controller
+        self._projects_path = os.path.normpath(projects_path)
+
+    def on_created(self, event):
+        self._handle_event(event)
+
+    def on_modified(self, event):
+        self._handle_event(event)
+
+    def on_moved(self, event):
+        self._handle_event(event)
+
+    def _handle_event(self, event):
+        if event.is_directory:
+            # Only react to direct child directories of the projects path
+            # to avoid noise from subdirectory changes in existing projects
+            for path in (getattr(event, "src_path", ""), getattr(event, "dest_path", "")):
+                if path and os.path.dirname(os.path.normpath(path)) == self._projects_path:
+                    self._controller._notify_projects_directory_event()
+                    return
+        else:
+            for path in (getattr(event, "src_path", ""), getattr(event, "dest_path", "")):
+                if path and path.endswith(".gns3"):
+                    self._controller._notify_projects_directory_event()
+                    return
+
+
 class Controller:
     """
     The controller is responsible to manage one or more computes.
@@ -69,11 +106,18 @@ class Controller:
         self._vars_loaded = False
         self._vars_file = Config.instance().controller_vars
         self._project_auto_open_task_handle = None
+        self._projects_observer = None
+        self._projects_scan_handle = None
+        self._projects_scan_lock = asyncio.Lock()
+        self._projects_monitor_loop = None
+        self._projects_monitor_thread_id = None
         log.info(f'Loading controller vars file "{self._vars_file}"')
 
     async def start(self, computes=None):
 
         log.info("Controller is starting")
+        self._projects_monitor_loop = asyncio.get_running_loop()
+        self._projects_monitor_thread_id = threading.get_ident()
         await self._install_base_configs()
         await self._install_custom_symbols()
         installed_disks = await self._install_builtin_disks()
@@ -140,6 +184,7 @@ class Controller:
             log.warning(str(e))
 
         await self.load_projects()
+        self._start_projects_monitor()
 
         # start to auto open projects (if configured) 5 seconds after the controller has started
         self._project_auto_open_task_handle = asyncio.get_event_loop().call_later(
@@ -184,6 +229,7 @@ class Controller:
     async def stop(self):
 
         log.info("Controller is stopping")
+        self._stop_projects_monitor()
         if self._project_auto_open_task_handle is not None and not self._project_auto_open_task_handle.cancelled():
             self._project_auto_open_task_handle.cancel()
         for project in self._projects.values():
@@ -301,21 +347,106 @@ class Controller:
         Preload the list of projects from disk
         """
 
-        server_config = Config.instance().settings.Server
+        async with self._projects_scan_lock:
-        projects_path = os.path.expanduser(server_config.projects_path)
+            server_config = Config.instance().settings.Server
+            projects_path = os.path.expanduser(server_config.projects_path)
+            os.makedirs(projects_path, exist_ok=True)
+            try:
+                for project_path in os.listdir(projects_path):
+                    project_dir = os.path.join(projects_path, project_path)
+                    if os.path.isdir(project_dir):
+                        for file in os.listdir(project_dir):
+                            if file.endswith(".gns3"):
+                                project_file = os.path.join(project_dir, file)
+                                try:
+                                    await self.load_project(project_file, load=False)
+                                except (ControllerError, NotImplementedError):
+                                    pass  # Skip not compatible projects
+                                except Exception as e:
+                                    log.warning(f"Could not load project from '{project_file}': {e}", exc_info=True)
+            except OSError as e:
+                log.error(str(e))
+
+    def _start_projects_monitor(self):
+        """
+        Monitor the projects directory for newly added projects.
+        """
+
+        if self._projects_observer is not None:
+            return
+
+        projects_path = self.projects_directory()
         os.makedirs(projects_path, exist_ok=True)
+
         try:
-            for project_path in os.listdir(projects_path):
+            observer = Observer()
-                project_dir = os.path.join(projects_path, project_path)
+            observer.schedule(_ProjectsDirectoryEventHandler(self, projects_path), projects_path, recursive=True)
-                if os.path.isdir(project_dir):
+            observer.start()
-                    for file in os.listdir(project_dir):
+            self._projects_observer = observer
-                        if file.endswith(".gns3"):
+            log.info(f"Watching projects directory '{projects_path}' for changes")
-                            try:
-                                await self.load_project(os.path.join(project_dir, file), load=False)
-                            except (ControllerError, NotImplementedError):
-                                pass  # Skip not compatible projects
         except OSError as e:
-            log.error(str(e))
+            log.warning(f"Could not watch projects directory '{projects_path}': {e}")
+
+    def _stop_projects_monitor(self):
+        """
+        Stop projects directory monitoring.
+        """
+
+        if self._projects_scan_handle is not None:
+            self._projects_scan_handle.cancel()
+            self._projects_scan_handle = None
+
+        self._projects_monitor_loop = None
+
+        observer = self._projects_observer
+        if observer is None:
+            return
+
+        self._projects_observer = None
+        observer.stop()
+        observer.join(timeout=2)
+
+    def _notify_projects_directory_event(self):
+        """
+        Callback invoked by watchdog threads when the projects directory changes.
+        """
+
+        loop = self._projects_monitor_loop
+        if loop is None:
+            return
+
+        if threading.get_ident() == self._projects_monitor_thread_id:
+            self._schedule_projects_scan()
+            return
+
+        try:
+            loop.call_soon_threadsafe(self._schedule_projects_scan)
+        except RuntimeError:
+            pass  # Event loop may be closed during shutdown
+
+    def _schedule_projects_scan(self, delay=0.5):
+        """
+        Debounce projects directory scans to avoid excessive rescans during copy operations.
+        """
+
+        if self._projects_scan_handle is not None:
+            self._projects_scan_handle.cancel()
+
+        loop = self._projects_monitor_loop or asyncio.get_running_loop()
+        self._projects_scan_handle = loop.call_later(delay, lambda: asyncio.create_task(self._scan_projects_directory()))
+
+    async def _scan_projects_directory(self):
+        """
+        Refresh loaded projects after a filesystem change.
+        """
+
+        self._projects_scan_handle = None
+        if self._projects_observer is None:
+            return  # Monitor was stopped, skip the scan
+        try:
+            await self.load_projects()
+        except Exception as e:
+            log.warning(f"Projects directory rescan failed: {e}")
 
 
     @staticmethod

tests/controller/test_controller.py

@@ -18,13 +18,16 @@
 import os
 import uuid
 import json
+import asyncio
 import pytest
 import socket
 from unittest.mock import MagicMock, patch
 from tests.utils import AsyncioMagicMock, asyncio_patch
+from watchdog.events import FileCreatedEvent, DirCreatedEvent
 
 from gns3server.controller.compute import Compute
 from gns3server.controller.controller_error import ControllerError, ControllerNotFoundError
+from gns3server.controller import _ProjectsDirectoryEventHandler
 from gns3server.version import __version__
 
 
@@ -110,6 +113,57 @@ async def test_load_projects(controller, projects_dir):
     mock_load_project.assert_called_with(os.path.join(projects_dir, "project1", "project1.gns3"), load=False)
 
 
+@pytest.mark.asyncio
+async def test_load_projects_skip_unexpected_errors(controller, projects_dir):
+
+    os.makedirs(os.path.join(projects_dir, "broken_project"))
+    with open(os.path.join(projects_dir, "broken_project", "broken.gns3"), "w+") as f:
+        f.write("")
+
+    with asyncio_patch("gns3server.controller.Controller.load_project", side_effect=Exception("boom")) as mock_load_project:
+        await controller.load_projects()
+    mock_load_project.assert_called_with(os.path.join(projects_dir, "broken_project", "broken.gns3"), load=False)
+
+
+def test_projects_directory_event_handler_filters_events(controller):
+
+    controller._notify_projects_directory_event = MagicMock()
+    handler = _ProjectsDirectoryEventHandler(controller, "/projects")
+
+    # Non-.gns3 file should be ignored
+    handler.on_created(FileCreatedEvent("/projects/project1/README.txt"))
+    assert controller._notify_projects_directory_event.call_count == 0
+
+    # .gns3 file creation should trigger
+    handler.on_created(FileCreatedEvent("/projects/project1/project1.gns3"))
+    assert controller._notify_projects_directory_event.call_count == 1
+
+    # Direct child directory creation should trigger
+    handler.on_created(DirCreatedEvent("/projects/project1"))
+    assert controller._notify_projects_directory_event.call_count == 2
+
+    # Deep subdirectory creation should be ignored
+    handler.on_created(DirCreatedEvent("/projects/project1/captures"))
+    assert controller._notify_projects_directory_event.call_count == 2
+
+
+@pytest.mark.asyncio
+async def test_schedule_projects_scan_is_debounced(controller):
+
+    scan_called = asyncio.Event()
+
+    async def _mark_scan_called(*args, **kwargs):
+        scan_called.set()
+
+    with asyncio_patch("gns3server.controller.Controller._scan_projects_directory") as mock_scan_projects:
+        mock_scan_projects.side_effect = _mark_scan_called
+        controller._projects_monitor_loop = asyncio.get_running_loop()
+        controller._schedule_projects_scan(delay=0.01)
+        controller._schedule_projects_scan(delay=0.01)
+        await asyncio.wait_for(scan_called.wait(), timeout=1)
+        assert mock_scan_projects.call_count == 1
+
+
 @pytest.mark.asyncio
 async def test_add_compute(controller):