fix(links): reserve ports on add, accept port name and auto, add port_in_use code

This commit is contained in:
Mark Paronyan committed 2026-10-07 15:41:04 +03:00
1 parent 2fb7056cb9
commit a9e87df644
10 files changed
+286 -21

No files matched your search

+16 -8
View File
@@ -276,7 +276,7 @@ class Link:
if port is None:
raise ControllerNotFoundError(f"Port {adapter_number}/{port_number} for {node.name} not found")
if port.link is not None:
raise ControllerError("Port is already used")
raise ControllerError("Port is already used", code="port_in_use")
self._link_type = port.link_type
@@ -313,17 +313,29 @@ class Link:
{"node": node, "adapter_number": adapter_number, "port_number": port_number, "port": port, "label": label}
)
if not batch:
port.link = self
if len(self._nodes) == 2 and not batch:
await self.create()
try:
await self.create()
except BaseException:
self.release_ports()
raise
for n in self._nodes:
n["node"].add_link(self)
n["port"].link = self
self._created = True
self._project.emit_notification("link.created", self.asdict())
if dump:
self._project.dump()
def release_ports(self):
for n in self._nodes:
if n["port"].link == self:
n["port"].link = None
n["node"].links.discard(self)
async def update_nodes(self, nodes):
for node_data in nodes:
node = self._project.get_node(node_data["node_id"])
@@ -352,11 +364,7 @@ class Link:
"""
Delete the link
"""
for n in self._nodes:
# It could be different of self if we rollback an already existing link
if n["port"].link == self:
n["port"].link = None
n["node"].remove_link(self)
self.release_ports()
async def reset(self):
"""