From a68e57dd2e4a4e70472daac4800cc850305b6677 Mon Sep 17 00:00:00 2001
From: Mark Paronyan <markparonian@gmail.com>
Date: Mon, 28 Sep 2026 05:08:39 +0000
Subject: [PATCH] fix(typing): resolve mypy errors in schemas.controller.nodes

---
 gns3server/schemas/controller/nodes.py | 16 ++++++++++------
 pyproject.toml                         |  1 -
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/gns3server/schemas/controller/nodes.py b/gns3server/schemas/controller/nodes.py
index 43d8ca5b4..9faf260d3 100644
--- a/gns3server/schemas/controller/nodes.py
+++ b/gns3server/schemas/controller/nodes.py
@@ -114,9 +114,9 @@ class NodeBase(BaseModel):
     Node data.
     """
 
-    compute_id: Union[UUID, str]
-    name: str
-    node_type: NodeType
+    compute_id: Optional[Union[UUID, str]] = None
+    name: Optional[str] = None
+    node_type: Optional[NodeType] = None
 
     node_id: Optional[UUID] = None
 
@@ -162,6 +162,9 @@ class NodeBase(BaseModel):
 
 
 class NodeCreate(NodeBase):
+    compute_id: Union[UUID, str]
+    name: str
+    node_type: NodeType
     node_id: UUID = Field(default_factory=uuid4)
 
 
@@ -170,12 +173,13 @@ class NodeUpdate(NodeBase):
     Data to update a node.
     """
 
-    compute_id: Optional[Union[UUID, str]] = None
-    name: Optional[str] = None
-    node_type: Optional[NodeType] = None
+    pass
 
 
 class Node(NodeBase):
+    compute_id: Union[UUID, str]
+    name: str
+    node_type: NodeType
     template_id: Optional[UUID] = Field(
         None, description="Template UUID from which the node has been created. Read only"
     )
diff --git a/pyproject.toml b/pyproject.toml
index c4806fbe4..16afd963b 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -384,7 +384,6 @@ module = [
   "gns3server.schemas.compute.qemu_nodes",  # 1
   "gns3server.schemas.compute.virtualbox_nodes",  # 2
   "gns3server.schemas.controller.computes",  # 6
-  "gns3server.schemas.controller.nodes",  # 3
   "gns3server.schemas.controller.projects",  # 2
   "gns3server.schemas.controller.settings",  # 3
   "gns3server.schemas.controller.templates.docker_templates",  # 1