NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-10-25 11:22:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(typing): resolve mypy errors in api.routes.compute.virtualbox_nodes

Browse Source
This commit is contained in:
Mark Paronyan 2026-09-28 05:41:14 +00:00
parent fed8aab86c
commit 83b80b8c52
No known key found for this signature in database
GPG Key ID: 8DC7338A87FE22F8
2 changed files with 25 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
gns3server/api/routes/compute/virtualbox_nodes.py
View File

@ -24,7 +24,7 @@ from fastapi import APIRouter, WebSocket, Depends, Path, status
from fastapi.encoders import jsonable_encoder from fastapi.encoders import jsonable_encoder
from fastapi.responses import StreamingResponse from fastapi.responses import StreamingResponse
from uuid import UUID from uuid import UUID
from typing import Union from typing import Any, Union
from gns3server import schemas from gns3server import schemas
from gns3server.compute.virtualbox import VirtualBox from gns3server.compute.virtualbox import VirtualBox
@ -33,7 +33,9 @@ from gns3server.compute.virtualbox.virtualbox_vm import VirtualBoxVM
from .dependencies.authentication import compute_authentication, ws_compute_authentication from .dependencies.authentication import compute_authentication, ws_compute_authentication
responses = {404: {"model": schemas.ErrorMessage, "description": "Could not find project or VirtualBox node"}} responses: dict[int | str, dict[str, Any]] = {
404: {"model": schemas.ErrorMessage, "description": "Could not find project or VirtualBox node"}
}
router = APIRouter(responses=responses, deprecated=True) router = APIRouter(responses=responses, deprecated=True)
@ -61,24 +63,24 @@ async def create_virtualbox_node(project_id: UUID, node_data: schemas.VirtualBox
""" """
vbox_manager = VirtualBox.instance() vbox_manager = VirtualBox.instance()
node_data = jsonable_encoder(node_data, exclude_unset=True) data = jsonable_encoder(node_data, exclude_unset=True)
vm = await vbox_manager.create_node( vm = await vbox_manager.create_node(
node_data.pop("name"), data.pop("name"),
str(project_id), str(project_id),
node_data.get("node_id"), data.get("node_id"),
node_data.pop("vmname"), data.pop("vmname"),
linked_clone=node_data.pop("linked_clone", False), linked_clone=data.pop("linked_clone", False),
console=node_data.get("console", None), console=data.get("console", None),
console_type=node_data.get("console_type", "telnet"), console_type=data.get("console_type", "telnet"),
adapters=node_data.get("adapters", 0), adapters=data.get("adapters", 0),
) )
if "ram" in node_data: if "ram" in data:
ram = node_data.pop("ram") ram = data.pop("ram")
if ram != vm.ram: if ram != vm.ram:
await vm.set_ram(ram) await vm.set_ram(ram)
for name, value in node_data.items(): for name, value in data.items():
if name != "node_id": if name != "node_id":
if hasattr(vm, name) and getattr(vm, name) != value: if hasattr(vm, name) and getattr(vm, name) != value:
setattr(vm, name, value) setattr(vm, name, value)
@ -103,10 +105,10 @@ async def update_virtualbox_node(
Update a VirtualBox node. Update a VirtualBox node.
""" """
node_data = jsonable_encoder(node_data, exclude_unset=True) data = jsonable_encoder(node_data, exclude_unset=True)
if "name" in node_data: if "name" in data:
name = node_data.pop("name") name = data.pop("name")
vmname = node_data.pop("vmname", None) vmname = data.pop("vmname", None)
if name != node.name: if name != node.name:
oldname = node.name oldname = node.name
node.name = name node.name = name
@ -118,20 +120,20 @@ async def update_virtualbox_node(
node.updated() node.updated()
raise e raise e
if "adapters" in node_data: if "adapters" in data:
adapters = node_data.pop("adapters") adapters = data.pop("adapters")
if adapters != node.adapters: if adapters != node.adapters:
await node.set_adapters(adapters) await node.set_adapters(adapters)
if "ram" in node_data: if "ram" in data:
ram = node_data.pop("ram") ram = data.pop("ram")
if ram != node.ram: if ram != node.ram:
await node.set_ram(ram) await node.set_ram(ram)
# update the console first to avoid issue if updating console type # update the console first to avoid issue if updating console type
node.console = node_data.pop("console", node.console) node.console = data.pop("console", node.console)
for name, value in node_data.items(): for name, value in data.items():
if hasattr(node, name) and getattr(node, name) != value: if hasattr(node, name) and getattr(node, name) != value:
setattr(node, name, value) setattr(node, name, value)

1
pyproject.toml
View File

@ -332,7 +332,6 @@ module = [
"gns3server.api.routes.compute.iou_nodes", # 15 "gns3server.api.routes.compute.iou_nodes", # 15
"gns3server.api.routes.compute.nat_nodes", # 10 "gns3server.api.routes.compute.nat_nodes", # 10
"gns3server.api.routes.compute.notifications", # 4 "gns3server.api.routes.compute.notifications", # 4
"gns3server.api.routes.compute.virtualbox_nodes", # 20
"gns3server.api.routes.compute.vmware_nodes", # 10 "gns3server.api.routes.compute.vmware_nodes", # 10
"gns3server.api.routes.compute.vpcs_nodes", # 9 "gns3server.api.routes.compute.vpcs_nodes", # 9
"gns3server.api.routes.controller.acl", # 5 "gns3server.api.routes.controller.acl", # 5