NgTech-LTD/gns3-server
2
0 Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-11-03 05:51:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Enhancement: Re-write current Telnet server implementation using telnetlib3 library

Browse Source
This commit is contained in:
Cristi committed 2026-03-24 13:23:45 +02:00
1 parent 77bea35298
commit 83558d4d9f
9 files changed
+454 -337
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

gns3server/compute/base_node.py
+1 -1
View File
@@ -436,7 +436,7 @@ class BaseNode:
echo=True
)
# warning: this will raise OSError exception if there is a problem...
telnet_server = await asyncio.start_server(server.run, self._manager.port_manager.console_host, external_port)
telnet_server = await server.start(self._manager.port_manager.console_host, external_port)
self._wrapper_telnet_servers.append(telnet_server)
async def start_wrap_console(self):
gns3server/compute/docker/docker_vm.py
+2 -6
View File
@@ -704,9 +704,7 @@ class DockerVM(BaseNode):
raise DockerError(f"Could not start auxiliary console process: {e}")
server = AsyncioTelnetServer(reader=process.stdout, writer=process.stdin, binary=True, echo=True)
try:
self._telnet_servers.append(
await asyncio.start_server(server.run, self._manager.port_manager.console_host, self.aux)
)
self._telnet_servers.append(await server.start(self._manager.port_manager.console_host, self.aux))
except OSError as e:
raise DockerError(
f"Could not start Telnet server on socket {self._manager.port_manager.console_host}:{self.aux}: {e}"
@@ -899,9 +897,7 @@ class DockerVM(BaseNode):
window_size_changed_callback=self._window_size_changed_callback,
)
try:
self._telnet_servers.append(
await asyncio.start_server(telnet.run, self._manager.port_manager.console_host, self.console)
)
self._telnet_servers.append(await telnet.start(self._manager.port_manager.console_host, self.console))
except OSError as e:
raise DockerError(
f"Could not start Telnet server on socket {self._manager.port_manager.console_host}:{self.console}: {e}"
gns3server/compute/iou/iou_vm.py
+1 -3
View File
@@ -651,9 +651,7 @@ class IOUVM(BaseNode):
reader=self._iou_process.stdout, writer=self._iou_process.stdin, binary=True, echo=True
)
try:
self._telnet_server = await asyncio.start_server(
server.run, self._manager.port_manager.console_host, self.console
)
self._telnet_server = await server.start(self._manager.port_manager.console_host, self.console)
except OSError as e:
await self.stop()
raise IOUError(
gns3server/compute/virtualbox/virtualbox_vm.py
+1 -3
View File
@@ -1019,9 +1019,7 @@ class VirtualBoxVM(BaseNode):
raise VirtualBoxError(f"Could not open serial pipe '{pipe_name}': {e}")
server = AsyncioTelnetServer(reader=self._remote_pipe, writer=self._remote_pipe, binary=True, echo=True)
try:
self._telnet_server = await asyncio.start_server(
server.run, self._manager.port_manager.console_host, self.console
)
self._telnet_server = await server.start(self._manager.port_manager.console_host, self.console)
except OSError as e:
self.project.emit(
"log.warning",
gns3server/compute/vmware/vmware_vm.py
+1 -3
View File
@@ -920,9 +920,7 @@ class VMwareVM(BaseNode):
raise VMwareError(f"Could not open serial pipe '{pipe_name}': {e}")
server = AsyncioTelnetServer(reader=self._remote_pipe, writer=self._remote_pipe, binary=True, echo=True)
try:
self._telnet_server = await asyncio.start_server(
server.run, self._manager.port_manager.console_host, self.console
)
self._telnet_server = await server.start(self._manager.port_manager.console_host, self.console)
except OSError as e:
self.project.emit(
"log.warning",