From 828a77048955ad88eb4770097cd85fe26a5bd63a Mon Sep 17 00:00:00 2001 From: YueGuobin Date: Thu, 11 Jun 2026 01:28:19 +0800 Subject: [PATCH] fix: Remove .json() calls on 204 responses for prune/install images --- gns3server/api/routes/mcp/images.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gns3server/api/routes/mcp/images.py b/gns3server/api/routes/mcp/images.py index 4b00c1a22..0022e1554 100644 --- a/gns3server/api/routes/mcp/images.py +++ b/gns3server/api/routes/mcp/images.py @@ -65,11 +65,13 @@ def delete_image_handler(params: dict[str, Any], gns3_ctx: dict[str, Any]) -> di def prune_images_handler(params: dict[str, Any], gns3_ctx: dict[str, Any]) -> dict[str, Any]: conn = _get_connector(gns3_ctx) - result = conn.http_call("delete", f"{conn.base_url}/images/prune").json() - return {"message": "Unused images pruned", "result": result} + # Returns 204 No Content on success (empty body, no .json()) + conn.http_call("delete", f"{conn.base_url}/images/prune") + return {"message": "Unused images pruned"} def install_images_handler(params: dict[str, Any], gns3_ctx: dict[str, Any]) -> dict[str, Any]: conn = _get_connector(gns3_ctx) - result = conn.http_call("post", f"{conn.base_url}/images/install").json() - return {"message": "Image installation requested", "result": result} + # Returns 204 No Content on success (empty body, no .json()) + conn.http_call("post", f"{conn.base_url}/images/install") + return {"message": "Image installation completed"}