NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-10-28 19:22:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(symbols): add CORS headers to symbol file responses

Browse Source 
FileResponse does not properly include CORS headers when served from
a different origin. This fix manually adds the Access-Control-Allow-Origin
header based on the request origin.

Fixes CORS policy errors when accessing symbol files from frontend
applications running on localhost:4200 or other origins.
This commit is contained in:
YueGuobin 2026-04-07 20:22:15 +08:00
parent ae8ef84668
commit 8041d2906c
No known key found for this signature in database
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gns3server/api/routes/controller/symbols.py
View File

@ -61,7 +61,7 @@ def get_symbols() -> List[dict]:
# FIXME: this is a temporary workaround due to a bug in the web-ui: https://github.com/GNS3/gns3-web-ui/issues/1466 # FIXME: this is a temporary workaround due to a bug in the web-ui: https://github.com/GNS3/gns3-web-ui/issues/1466
# dependencies=[Depends(has_privilege("Symbol.Audit"))] # dependencies=[Depends(has_privilege("Symbol.Audit"))]
) )
async def get_symbol(symbol_id: str) -> FileResponse: async def get_symbol(symbol_id: str, request: Request) -> Response:
""" """
Download a symbol file. Download a symbol file.
@ -71,7 +71,12 @@ async def get_symbol(symbol_id: str) -> FileResponse:
controller = Controller.instance() controller = Controller.instance()
try: try:
symbol = controller.symbols.get_path(symbol_id) symbol = controller.symbols.get_path(symbol_id)
return FileResponse(symbol) return FileResponse(
symbol,
headers={
"Access-Control-Allow-Origin": request.headers.get("origin", "*"),
}
)
except (KeyError, OSError) as e: except (KeyError, OSError) as e:
raise ControllerNotFoundError(f"Could not get symbol file: {e}") raise ControllerNotFoundError(f"Could not get symbol file: {e}")