fix: never allow the projects directory to become a project directory

Loading a .gns3 placed directly in the projects root registered the
shared projects directory as the project path (load_project derives
the path from the file's parent directory). Deleting such an entry ran
rmtree on the projects directory itself, wiping every project until a
root-owned file stopped it, and left a zombie entry in the controller.

Three layers of protection:

- Controller.load_project() refuses a .gns3 whose parent directory is
  the projects directory; the normal subdirectory layout is unaffected
- the Project.path setter rejects the projects directory itself and
  its ancestors, closing the same hole for POST/PUT with an explicit
  path
- Project.delete() uses realpath + commonpath instead of commonprefix:
  entries whose path is the projects root are refused, and sibling
  directories sharing a string prefix (/srv/projects-evil vs
  /srv/projects) are no longer treated as inside the projects dir

Also removes the project_load MCP tool: loading by raw server
filesystem path is a footgun for automated clients; projects can still
be opened by project_id via the remaining tools.
This commit is contained in:
YueGuobin committed 2026-08-25 13:17:37 +08:00
1 parent 629bb9194f
commit 702fc1f6d9
11 files changed
+125 -28

No files matched your search

+31
View File
@@ -741,6 +741,37 @@ async def test_delete(project):
assert not os.path.exists(project.path)
@pytest.mark.asyncio
async def test_delete_refuses_to_delete_projects_directory(project, projects_dir):
"""
A poisoned entry whose path is the projects directory itself (a .gns3
loaded directly from the projects root before the guard existed) must
not be deletable: rmtree would wipe every project on the controller.
"""
other_project = os.path.join(projects_dir, "another-project")
os.makedirs(other_project, exist_ok=True)
# Simulate the poisoned in-memory state directly: the path setter now
# rejects such an assignment, but a long-running server can still hold
# an entry created before the fix.
project._path = projects_dir
with pytest.raises(ControllerError):
await project.delete()
assert os.path.exists(other_project)
def test_path_setter_rejects_projects_directory(project, projects_dir):
"""
The projects directory itself must never become a project directory.
"""
with pytest.raises(ControllerForbiddenError):
project.path = projects_dir
assert project.path == os.path.join(projects_dir, project.id)
@pytest.mark.asyncio
async def test_delete_does_not_start_nodes(project):
"""