NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-09-06 01:55:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Generate independent short-lived JWT for pcap download

Browse Source 
No longer depends on the original token type (JWT or API key).
Always creates a fresh 10-min JWT for the download URL.
This commit is contained in:
YueGuobin 2026-06-14 13:49:24 +08:00
parent 754eab9609
commit 678b1868f5
No known key found for this signature in database
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gns3server/api/routes/mcp/links.py
View File

@ -27,6 +27,8 @@ from concurrent.futures import ThreadPoolExecutor, as_completed
import logging
from gns3server.services import auth_service
log = logging.getLogger(__name__)
BATCH_MAX_WORKERS = 10
@ -189,12 +191,13 @@ def download_capture_file_handler(params: dict[str, Any], gns3_ctx: dict[str, An
if not project_id or not link_id:
return {"error": "project_id and link_id are required"}
download_url = f"{gns3_ctx['server_url']}/v3/projects/{project_id}/links/{link_id}/capture/file"
auth_token = gns3_ctx['jwt_token']
# Generate a short-lived download token (10 min) so the user can curl without exposing their API key
download_token = auth_service.create_access_token("mcp-download", expires_in=10)
return {
"link_id": link_id,
"download_url": download_url,
"curl_command": f"curl -L -o capture.pcap -H 'Authorization: Bearer {auth_token}' '{download_url}'",
"note": "Use the curl command to download the PCAP capture file. "
"curl_command": f"curl -L -o capture.pcap -H 'Authorization: Bearer {download_token}' '{download_url}'",
"note": "This download link expires in 10 minutes. "
"The file is in pcap format and can be analyzed with Wireshark or tcpdump.",
}