From 515ae8dcfbf5f7800015ba321d2abce760116c77 Mon Sep 17 00:00:00 2001 From: Mark Paronyan Date: Mon, 28 Sep 2026 04:54:42 +0000 Subject: [PATCH] fix(typing): resolve mypy errors in schemas.compute.virtualbox_nodes --- gns3server/schemas/compute/virtualbox_nodes.py | 12 +++++++----- pyproject.toml | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/gns3server/schemas/compute/virtualbox_nodes.py b/gns3server/schemas/compute/virtualbox_nodes.py index 06ad9f831..d05692ebc 100644 --- a/gns3server/schemas/compute/virtualbox_nodes.py +++ b/gns3server/schemas/compute/virtualbox_nodes.py @@ -56,8 +56,8 @@ class VirtualBoxBase(BaseModel): Common VirtualBox node properties. """ - name: str - vmname: str = Field(..., description="VirtualBox VM name (in VirtualBox itself)") + name: Optional[str] = None + vmname: Optional[str] = None node_id: Optional[UUID] = None linked_clone: Optional[bool] = Field(None, description="Whether the VM is a linked clone or not") usage: Optional[str] = Field(None, description="How to use the node") @@ -78,7 +78,8 @@ class VirtualBoxCreate(VirtualBoxBase): Properties to create a VirtualBox node. """ - pass + name: str + vmname: str = Field(..., description="VirtualBox VM name (in VirtualBox itself)") class VirtualBoxUpdate(VirtualBoxBase): @@ -86,11 +87,12 @@ class VirtualBoxUpdate(VirtualBoxBase): Properties to update a VirtualBox node. """ - name: Optional[str] = None - vmname: Optional[str] = None + pass class VirtualBox(VirtualBoxBase): + name: str + vmname: str = Field(..., description="VirtualBox VM name (in VirtualBox itself)") project_id: UUID = Field(..., description="Project ID") node_directory: Optional[str] = Field(None, description="Path to the node working directory (read only)") status: NodeStatus = Field(..., description="Container status (read only)") diff --git a/pyproject.toml b/pyproject.toml index 86353ab97..7e068d69e 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -377,7 +377,6 @@ module = [ "gns3server.schemas.compute.atm_switch_nodes", # 5 "gns3server.schemas.compute.dynamips_nodes", # 1 "gns3server.schemas.compute.nat_nodes", # 1 - "gns3server.schemas.compute.virtualbox_nodes", # 2 "gns3server.schemas.compute.vmware_nodes", # 3 "gns3server.schemas.compute.vpcs_nodes", # 1 "gns3server.schemas.controller.appliances", # 1