Rename console methods in port manager to use the generic tcp term in the name.

Fixes bug when a console port is allocated to a Ghost VM instance and not released.
Warnings at exit when TCP/UDP ports are still allocated.

tests/modules/iou/test_iou_vm.py

@@ -165,7 +165,7 @@ def test_close(vm, port_manager, loop):
             port = vm.console
             loop.run_until_complete(asyncio.async(vm.close()))
             # Raise an exception if the port is not free
-            port_manager.reserve_console_port(port)
+            port_manager.reserve_tcp_port(port)
             assert vm.is_running() is False
 
 

tests/modules/qemu/test_qemu_vm.py

@@ -138,9 +138,9 @@ def test_close(vm, port_manager, loop):
         loop.run_until_complete(asyncio.async(vm.close()))
 
         # Raise an exception if the port is not free
-        port_manager.reserve_console_port(console_port)
+        port_manager.reserve_tcp_port(console_port)
         # Raise an exception if the port is not free
-        port_manager.reserve_console_port(monitor_port)
+        port_manager.reserve_tcp_port(monitor_port)
 
         assert vm.is_running() is False
 

tests/modules/test_port_manager.py

@@ -20,8 +20,8 @@ import pytest
 from gns3server.modules.port_manager import PortManager
 
 
-def test_reserve_console_port():
+def test_reserve_tcp_port():
     pm = PortManager()
-    pm.reserve_console_port(4242)
+    pm.reserve_tcp_port(4242)
     with pytest.raises(aiohttp.web.HTTPConflict):
-        pm.reserve_console_port(4242)
+        pm.reserve_tcp_port(4242)

tests/modules/vpcs/test_vpcs_vm.py

@@ -191,14 +191,14 @@ def test_get_startup_script_using_default_script(vm):
 
 
 def test_change_console_port(vm, port_manager):
-    port1 = port_manager.get_free_console_port()
-    port2 = port_manager.get_free_console_port()
-    port_manager.release_console_port(port1)
-    port_manager.release_console_port(port2)
+    port1 = port_manager.get_free_tcp_port()
+    port2 = port_manager.get_free_tcp_port()
+    port_manager.release_tcp_port(port1)
+    port_manager.release_tcp_port(port2)
     vm.console = port1
     vm.console = port2
     assert vm.console == port2
-    port_manager.reserve_console_port(port1)
+    port_manager.reserve_tcp_port(port1)
 
 
 def test_change_name(vm, tmpdir):
@@ -219,5 +219,5 @@ def test_close(vm, port_manager, loop):
             port = vm.console
             loop.run_until_complete(asyncio.async(vm.close()))
             # Raise an exception if the port is not free
-            port_manager.reserve_console_port(port)
+            port_manager.reserve_tcp_port(port)
             assert vm.is_running() is False