mirror of
https://github.com/GNS3/gns3-server.git
synced 2026-11-03 05:51:15 +02:00
feat: add client information logging to MCP connection rejection
Add reusable utility for extracting client information from ASGI scope:
- Create gns3server/utils/request_utils.py with extract_client_info()
- Extract client IP, port, path, method, and authenticated username
- Format comprehensive log messages with client context
Benefits:
- Better observability for connection rejection events
- Reusable utility for other modules
- Consistent client logging format across codebase
- Helps diagnose timing issues during server startup
Usage:
from gns3server.utils.request_utils import extract_client_info
client_info = extract_client_info(scope, auth_service)
log.warning(f"Connection rejected - Client: {client_info['host']}:{client_info['port']} ({client_info['user_info']})")
This commit is contained in:
2 files changed
+97
No files matched your search
@@ -44,6 +44,7 @@ from mcp.server.transport_security import TransportSecuritySettings
|
||||
|
||||
from gns3server.config import Config
|
||||
from gns3server.services import auth_service
|
||||
from gns3server.utils.request_utils import extract_client_info
|
||||
from .projects import (
|
||||
list_projects_handler, get_project_handler, create_project_handler,
|
||||
delete_project_handler, open_project_handler, close_project_handler,
|
||||
@@ -516,6 +517,11 @@ def _make_auth_wrapper(inner_app):
|
||||
server_ready = await wait_for_mcp_ready()
|
||||
if not server_ready:
|
||||
# Server initialization timed out - return 503 Service Unavailable
|
||||
client_info = extract_client_info(scope, auth_service)
|
||||
log.warning(
|
||||
f"Rejecting MCP connection - GNS3 server initialization not complete. "
|
||||
f"Client: {client_info['host']}:{client_info['port']} ({client_info['user_info']}, Path: {client_info['path']})"
|
||||
)
|
||||
response = Response(
|
||||
"GNS3 server initialization not complete - please retry later",
|
||||
status_code=503
|
||||
|
||||
Reference in new issue
Block a user