Use Pydantic to validate the server config file.

gns3server/api/routes/compute/compute.py

@@ -83,8 +83,7 @@ def compute_version() -> dict:
     Retrieve the server version number.
     """
 
-    config = Config.instance()
-    local_server = config.get_section_config("Server").getboolean("local", False)
+    local_server = Config.instance().settings.Server.local
     return {"version": __version__, "local": local_server}
 
 
@@ -153,8 +152,7 @@ async def create_qemu_image(image_data: schemas.QemuImageCreate):
     """
 
     if os.path.isabs(image_data.path):
-        config = Config.instance()
-        if config.get_section_config("Server").getboolean("local", False) is False:
+        if Config.instance().settings.Server.local is False:
             raise HTTPException(status_code=status.HTTP_403_FORBIDDEN)
 
     await Qemu.instance().create_disk(image_data.qemu_img, image_data.path, jsonable_encoder(image_data, exclude_unset=True))
@@ -169,8 +167,7 @@ async def update_qemu_image(image_data: schemas.QemuImageUpdate):
     """
 
     if os.path.isabs(image_data.path):
-        config = Config.instance()
-        if config.get_section_config("Server").getboolean("local", False) is False:
+        if Config.instance().settings.Server.local is False:
             raise HTTPException(status_code=status.HTTP_403_FORBIDDEN)
 
     if image_data.extend:

gns3server/api/routes/compute/qemu_nodes.py

@@ -148,12 +148,7 @@ async def start_qemu_node(node: QemuVM = Depends(dep_node)):
     """
 
     qemu_manager = Qemu.instance()
-    hardware_accel = qemu_manager.config.get_section_config("Qemu").getboolean("enable_hardware_acceleration", True)
-    if sys.platform.startswith("linux"):
-        # the enable_kvm option was used before version 2.0 and has priority
-        enable_kvm = qemu_manager.config.get_section_config("Qemu").getboolean("enable_kvm")
-        if enable_kvm is not None:
-            hardware_accel = enable_kvm
+    hardware_accel = qemu_manager.config.settings.Qemu.enable_hardware_acceleration
     if hardware_accel and "-no-kvm" not in node.options and "-no-hax" not in node.options:
         pm = ProjectManager.instance()
         if pm.check_hardware_virtualization(node) is False:

gns3server/api/routes/controller/controller.py

@@ -43,8 +43,7 @@ async def shutdown():
     Shutdown the local server
     """
 
-    config = Config.instance()
-    if config.get_section_config("Server").getboolean("local", False) is False:
+    if Config.instance().settings.Server.local is False:
         raise ControllerForbiddenError("You can only stop a local server")
 
     log.info("Start shutting down the server")
@@ -76,8 +75,7 @@ def get_version():
     Return the server version number.
     """
 
-    config = Config.instance()
-    local_server = config.get_section_config("Server").getboolean("local", False)
+    local_server = Config.instance().settings.Server.local
     return {"version": __version__, "local": local_server}
 
 

gns3server/api/routes/controller/projects.py

@@ -183,9 +183,8 @@ async def load_project(path: str = Body(..., embed=True)):
     """
 
     controller = Controller.instance()
-    config = Config.instance()
     dot_gns3_file = path
-    if config.get_section_config("Server").getboolean("local", False) is False:
+    if Config.instance().settings.Server.local is False:
         log.error("Cannot load '{}' because the server has not been started with the '--local' parameter".format(dot_gns3_file))
         raise ControllerForbiddenError("Cannot load project when server is not local")
     project = await controller.load_project(dot_gns3_file,)
@@ -313,8 +312,7 @@ async def import_project(project_id: UUID, request: Request, path: Optional[Path
     """
 
     controller = Controller.instance()
-    config = Config.instance()
-    if not config.get_section_config("Server").getboolean("local", False):
+    if Config.instance().settings.Server.local is False:
         raise ControllerForbiddenError("The server is not local")
 
     # We write the content to a temporary location and after we extract it all.
@@ -353,8 +351,7 @@ async def duplicate_project(project_data: schemas.ProjectDuplicate, project: Pro
     """
 
     if project_data.path:
-        config = Config.instance()
-        if config.get_section_config("Server").getboolean("local", False) is False:
+        if Config.instance().settings.Server.local is False:
             raise ControllerForbiddenError("The server is not a local server")
         location = project_data.path
     else: