mirror of
https://github.com/GNS3/gns3-server.git
synced 2026-11-20 21:25:14 +02:00
test(e2e): assert the L2-anchor spec's server-side guarantees
The spec's gns3-server alignment section promised three assertions the suites never carried; they land in harness.py and run in every kernel scenario (plus the relay controls' anchor checks): - E.1 assert_pure_l2: anchors and bridges carry no L3 identity (addrgenmode none, no address in /proc/net/if_inet6, no ip -o -4 addr) -- the kernel scenarios' anchors and per-link/switch bridges, relay-mode anchors and the switch's relay TAPs alike (hardening is a creation-time property, not a datapath one); - E.2 assert_idle_silence (Dynamips suite): guest interfaces shut to silence IOS's own CDP/keepalives, settle 2.5 s, then a 5 s window of zero traffic over both anchors and the per-link bridge; - assert_forwarding: every attached port reports brport/state == 3 -- a bridge left DOWN keeps its ports disabled and forwards nothing, with no error anywhere; the assertion is the only signal. harness.l2only_supported() probes a throwaway uBridge once (link l2only against a nonexistent device: 208 = command present, 202-Unknown command = old build); without the command the assertions skip -- the spec's degradation contract, mirroring the tc-capability skip. The first live run caught a fifth-creator gap: the switch's relay port TAPs (minted implicitly by bridge add_nio_tap) carried a live fe80::. Delivered uBridge-side per the spec (fb72758: the transient TAP is hardened at creation, attaches untouched); the server needed no change, and the relay-control E.1 check is that creator's end-to-end coverage.
This commit is contained in:
5 files changed
+215
-2
No files matched your search
@@ -139,6 +139,18 @@ def test_ethernet_switch_kernel_fast_path():
|
||||
baseline = harness.wait_ping(c1, "10.1.1.2")
|
||||
assert baseline["success"] == 100, baseline["raw"]
|
||||
|
||||
# L2-anchor spec §E.1: the absorbed anchors and the switch bridge
|
||||
# carry no L3 identity (skipped on a uBridge without `link l2only`),
|
||||
# and the joined ports are FORWARDING — the silent-failure guard.
|
||||
if harness.l2only_supported():
|
||||
harness.assert_pure_l2(a1)
|
||||
harness.assert_pure_l2(a2)
|
||||
harness.assert_pure_l2(sw_bridge)
|
||||
else:
|
||||
print(".. uBridge without link l2only: skipping the §E.1 assertions")
|
||||
harness.assert_forwarding(a1)
|
||||
harness.assert_forwarding(a2)
|
||||
|
||||
# VLAN programming on absorbed anchors: different access VLANs
|
||||
# isolate, the same VLAN bridges again.
|
||||
compute.call(
|
||||
@@ -274,6 +286,12 @@ def test_ethernet_switch_relay_control():
|
||||
members = harness.bridge_members(sw_bridge)
|
||||
assert members == sorted([f"{sw_bridge}-0", f"{sw_bridge}-1"]), members
|
||||
assert a1 not in members
|
||||
if harness.l2only_supported():
|
||||
# creation-time hardening applies on the relay too: the switch's
|
||||
# own port TAPs and its bridge are pure L2
|
||||
for member in members:
|
||||
harness.assert_pure_l2(member)
|
||||
harness.assert_pure_l2(sw_bridge)
|
||||
|
||||
harness.configure_ios(c1, "R1", eth_ip="10.1.1.1")
|
||||
harness.configure_ios(c2, "R2", eth_ip="10.1.1.2")
|
||||
|
||||
Reference in new issue
Block a user