From 269e7aaa672953f5d4bb82bea76de7e0b4c309b8 Mon Sep 17 00:00:00 2001 From: Mark Paronyan Date: Wed, 30 Sep 2026 20:45:47 +0300 Subject: [PATCH] chore(ruff): drop resolved trivia rules from the ignore baseline --- pyproject.toml | 67 +++++++++++++------------------------------------- 1 file changed, 17 insertions(+), 50 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index f979b5eb3..c72e963f9 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -97,14 +97,11 @@ ignore = [ "E402", # 129 module-import-not-at-top-of-file "E501", # 655 line-too-long "F401", # 300 unused-import - "F541", # 16 f-string-missing-placeholders "F841", # 32 unused-variable "I001", # 441 unsorted-imports "PLW0603", # 21 global-statement "PLW2901", # 30 redefined-loop-name - "RUF010", # 65 explicit-f-string-type-conversion "RUF012", # 23 mutable-class-default - "RUF013", # 40 implicit-optional "RUF036", # 22 none-not-at-end-of-union "RUF059", # 29 unused-unpacked-variable "S101", # 19 assert @@ -112,11 +109,9 @@ ignore = [ "S110", # 23 try-except-pass "UP006", # 270 non-pep585-annotation "UP007", # 81 non-pep604-annotation-union - "UP009", # 51 utf8-encoding-declaration "UP032", # 560 f-string "UP035", # 106 deprecated-import "UP045", # 1100 non-pep604-annotation-optional - "W293", # 661 blank-line-with-whitespace ] [tool.ruff.lint.mccabe] @@ -141,33 +136,17 @@ extend-immutable-calls = [ "tests/**" = ["S101", "S105", "S106", "S108"] # Baseline: existing violations of rules that are enforced everywhere else. # Remove entries one small PR at a time. Never add new ones. -"gns3server/agent/__init__.py" = ["LOG015", "RUF022"] -"gns3server/agent/gns3_copilot/agent/context_manager.py" = ["RUF005", "RUF100"] +"gns3server/agent/__init__.py" = ["LOG015"] "gns3server/agent/gns3_copilot/agent/gns3_copilot.py" = ["DTZ003"] "gns3server/agent/gns3_copilot/agent_service.py" = ["C901", "DTZ003"] "gns3server/agent/gns3_copilot/chat_sessions_repository.py" = ["DTZ003", "S608"] -"gns3server/agent/gns3_copilot/gns3_client/__init__.py" = ["RUF022"] -"gns3server/agent/gns3_copilot/gns3_client/context_helpers.py" = ["RUF022"] -"gns3server/agent/gns3_copilot/skills/__init__.py" = ["RUF022"] -"gns3server/agent/gns3_copilot/skills/loader.py" = ["UP015"] -"gns3server/agent/gns3_copilot/skills/manager.py" = ["UP037"] "gns3server/agent/gns3_copilot/skills/registry.py" = ["C901"] -"gns3server/agent/gns3_copilot/tools_v2/__init__.py" = ["RUF022"] -"gns3server/agent/gns3_copilot/tools_v2/config_tools_nornir.py" = ["RUF100"] -"gns3server/agent/gns3_copilot/tools_v2/display_tools_nornir.py" = ["RUF100"] "gns3server/agent/gns3_copilot/tools_v2/gns3_packet_filter.py" = ["PLW1510", "S603", "S607"] -"gns3server/agent/gns3_copilot/tools_v2/packet_analysis_tool.py" = ["PLW1510", "RUF005", "S603", "S607"] -"gns3server/agent/gns3_copilot/tools_v2/vpcs_tools_netmiko.py" = ["RUF100"] -"gns3server/agent/gns3_copilot/utils/__init__.py" = ["RUF022"] -"gns3server/agent/gns3_copilot/utils/custom_netmiko/__init__.py" = ["RUF100"] +"gns3server/agent/gns3_copilot/tools_v2/packet_analysis_tool.py" = ["PLW1510", "S603", "S607"] "gns3server/agent/gns3_copilot/utils/custom_netmiko/huawei_ce.py" = ["S107"] "gns3server/agent/gns3_copilot/utils/custom_netmiko/ruijie_telnet.py" = ["LOG015"] -"gns3server/agent/gns3_copilot/utils/custom_netmiko/scripts/list_netmiko_telnet_devices.py" = ["DTZ005", "UP024"] -"gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py" = ["RUF100"] -"gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py" = ["RUF100"] -"gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py" = ["RUF100"] +"gns3server/agent/gns3_copilot/utils/custom_netmiko/scripts/list_netmiko_telnet_devices.py" = ["DTZ005"] "gns3server/agent/gns3_copilot/utils/custom_netmiko/vpcs_telnet.py" = ["S107"] -"gns3server/agent/gns3_copilot/utils/gns3_drawing_utils.py" = ["RUF100"] "gns3server/agent/gns3_copilot/utils/message_converters.py" = ["RUF019"] "gns3server/agent/gns3_copilot/utils/parse_tool_content.py" = ["C901", "DTZ003"] "gns3server/agent/mcp/__init__.py" = ["RUF003"] @@ -175,21 +154,15 @@ extend-immutable-calls = [ "gns3server/agent/web_wireshark/manager.py" = ["C901"] "gns3server/agent/web_wireshark/setup_wireshark_image.py" = ["PLW1510", "S603", "S607"] "gns3server/agent/web_wireshark/stats.py" = ["ASYNC221", "PLW1510", "S603", "S607"] -"gns3server/api/routes/compute/notifications.py" = ["W291"] "gns3server/api/routes/compute/qemu_nodes.py" = ["F811"] -"gns3server/api/routes/controller/controller.py" = ["UP012"] "gns3server/api/routes/controller/dependencies/authentication.py" = ["S105", "S106"] "gns3server/api/routes/controller/links.py" = ["E722"] -"gns3server/api/routes/controller/netmiko.py" = ["RUF100"] -"gns3server/api/routes/controller/nodes.py" = ["C901", "RUF019", "UP024"] -"gns3server/api/routes/controller/projects.py" = ["UP012"] +"gns3server/api/routes/controller/nodes.py" = ["C901", "RUF019"] "gns3server/api/routes/controller/templates.py" = ["S324"] "gns3server/api/routes/controller/users.py" = ["S105", "S106"] -"gns3server/api/routes/index.py" = ["RUF021"] "gns3server/compute/base_node.py" = ["C901", "RUF019"] -"gns3server/compute/builtin/nodes/cloud.py" = ["E713"] "gns3server/compute/docker/__init__.py" = ["B006", "C901"] -"gns3server/compute/docker/docker_vm.py" = ["B006", "C901", "E731", "RUF003", "RUF006", "S108", "UP031"] +"gns3server/compute/docker/docker_vm.py" = ["B006", "C901", "E731", "RUF003", "RUF006", "S108"] "gns3server/compute/docker/iol_docker_vm.py" = ["RUF002", "S108"] "gns3server/compute/docker/vendor_docker_vm.py" = ["RUF002", "S108"] "gns3server/compute/dynamips/__init__.py" = ["C901"] @@ -198,11 +171,10 @@ extend-immutable-calls = [ "gns3server/compute/iou/iou_vm.py" = ["C901", "S108", "S324"] "gns3server/compute/iou/utils/iou_export.py" = ["C901", "RUF003"] "gns3server/compute/project.py" = ["DTZ006", "S324"] -"gns3server/compute/qemu/qemu_vm.py" = ["ASYNC220", "B009", "C901", "RUF003", "S603"] -"gns3server/compute/qemu/utils/ziputils.py" = ["RUF005", "UP031"] +"gns3server/compute/qemu/qemu_vm.py" = ["ASYNC220", "C901", "RUF003", "S603"] "gns3server/compute/ubridge/ubridge_hypervisor.py" = ["C901"] -"gns3server/compute/virtualbox/virtualbox_vm.py" = ["C901", "RUF005", "S314"] -"gns3server/compute/vmware/__init__.py" = ["C901", "UP015"] +"gns3server/compute/virtualbox/virtualbox_vm.py" = ["C901", "S314"] +"gns3server/compute/vmware/__init__.py" = ["C901"] "gns3server/compute/vmware/vmware_vm.py" = ["C901"] "gns3server/compute/vpcs/vpcs_vm.py" = ["B018"] "gns3server/config.py" = ["B905", "C901"] @@ -220,52 +192,47 @@ extend-immutable-calls = [ "gns3server/controller/project.py" = ["ASYNC110", "C901", "RUF006", "RUF019"] "gns3server/controller/topology.py" = ["C901"] "gns3server/controller/udp_link.py" = ["C901"] -"gns3server/db/models/base.py" = ["UP031"] -"gns3server/db/repositories/llm_model_configs.py" = ["DTZ003", "RUF005", "RUF019"] +"gns3server/db/repositories/llm_model_configs.py" = ["DTZ003", "RUF019"] "gns3server/db/repositories/rbac.py" = ["C901"] -"gns3server/db/tasks.py" = ["B009", "RUF006", "RUF019", "UP004"] -"gns3server/db_migrations/versions/7ceeddd9c9a8_init.py" = ["W291"] +"gns3server/db/tasks.py" = ["RUF006", "RUF019"] "gns3server/db_migrations/versions/ec4b7b198555_convert_pickletype_fields_to_json.py" = ["S301", "S608"] -"gns3server/logger.py" = ["PLW0127", "UP031"] -"gns3server/main.py" = ["UP031"] +"gns3server/logger.py" = ["PLW0127"] "gns3server/schemas/controller/settings.py" = ["S105"] "gns3server/schemas/controller/templates/docker_templates.py" = ["W292"] "gns3server/schemas/controller/tokens.py" = ["S105"] "gns3server/server.py" = ["DTZ011", "RUF006", "UP036"] "gns3server/services/authentication.py" = ["S105"] "gns3server/services/templates.py" = ["W292"] -"gns3server/utils/__init__.py" = ["S324", "UP031"] +"gns3server/utils/__init__.py" = ["S324"] "gns3server/utils/asyncio/__init__.py" = ["RUF006"] -"gns3server/utils/asyncio/aiozipstream.py" = ["C901", "UP031"] +"gns3server/utils/asyncio/aiozipstream.py" = ["C901"] "gns3server/utils/asyncio/raw_command_server.py" = ["B006"] "gns3server/utils/asyncio/telnet_server.py" = ["RUF006"] -"gns3server/utils/images.py" = ["RUF021", "S324"] +"gns3server/utils/images.py" = ["S324"] "gns3server/utils/packet_filter_validation.py" = ["PLW1510", "S603", "S607", "W292"] "gns3server/utils/picture.py" = ["C901"] "gns3server/utils/port_allocator.py" = ["S324"] -"gns3server/utils/uninstall_ai_features.py" = ["PLW1510", "S603", "UP015"] +"gns3server/utils/uninstall_ai_features.py" = ["PLW1510", "S603"] "gns3server/utils/vmnet.py" = ["S605", "S607"] "gns3server/utils/websocket_to_websocket.py" = ["C901"] "gns3server/utils/zipfile_zstd/__init__.py" = ["F403"] "gns3server/version.py" = ["S607"] "scripts/extract_mermaid.py" = ["C901", "PLW1510", "S603", "S607"] "scripts/tag.py" = ["S603", "S607"] -"scripts/welcome.py" = ["C901", "E722", "PLW1510", "S108", "S112", "S603", "S605", "S606", "S607", "W291"] +"scripts/welcome.py" = ["C901", "E722", "PLW1510", "S108", "S112", "S603", "S605", "S606", "S607"] "tests/agent/mcp/test_handlers.py" = ["B905"] "tests/agent/mcp/test_tool_params.py" = ["C901"] "tests/api/routes/controller/test_images.py" = ["S324", "W292"] "tests/api/routes/controller/test_links.py" = ["RUF015", "W292"] "tests/api/routes/controller/test_users.py" = ["F811"] "tests/compute/docker/test_docker.py" = ["B018"] -"tests/compute/docker/test_docker_vm.py" = ["F811", "UP004"] +"tests/compute/docker/test_docker_vm.py" = ["F811"] "tests/compute/docker/test_iol_docker_vm.py" = ["RUF003", "RUF015"] "tests/compute/docker/test_vendor_docker_vm.py" = ["RUF015"] "tests/compute/qemu/test_qemu_vm.py" = ["E741"] "tests/compute/test_project.py" = ["RUF003", "RUF064", "S103"] "tests/compute/virtualbox/test_virtualbox_manager.py" = ["B011"] "tests/compute/vpcs/test_vpcs_vm.py" = ["RUF003"] -"tests/controller/gns3vm/test_vmware_gns3_vm.py" = ["UP015"] -"tests/controller/test_export_project.py" = ["E713"] "tests/controller/test_import_project.py" = ["F811"] "tests/controller/test_marker.py" = ["B006"] "tests/controller/test_node.py" = ["E711", "F811"]