Filter support for Docker

Fix #1110

tests/compute/docker/test_docker_vm.py

@@ -704,6 +704,7 @@ def test_add_ubridge_connection(loop, vm):
         call.send('bridge start_capture bridge0 "/tmp/capture.pcap"'),
         call.send('bridge start bridge0')
     ]
+    assert 'bridge0' in vm._bridges
     # We need to check any_order ortherwise mock is confused by asyncio
     vm._ubridge_hypervisor.assert_has_calls(calls, any_order=True)
 
@@ -722,6 +723,7 @@ def test_add_ubridge_connection_none_nio(loop, vm):
         call.send('docker move_to_ns tap-gns3-e0 42 eth0'),
 
     ]
+    assert 'bridge0' in vm._bridges
     # We need to check any_order ortherwise mock is confused by asyncio
     vm._ubridge_hypervisor.assert_has_calls(calls, any_order=True)
 
@@ -763,6 +765,35 @@ def test_adapter_add_nio_binding(vm, loop):
     assert vm._ethernet_adapters[0].get_nio(0) == nio
 
 
+def test_adapter_udpate_nio_binding(vm, loop):
+    vm._ubridge_apply_filters = AsyncioMagicMock()
+    vm._bridges = set(('bridge0', ))
+    nio = {"type": "nio_udp",
+           "lport": 4242,
+           "rport": 4343,
+           "rhost": "127.0.0.1"}
+    nio = vm.manager.create_nio(nio)
+    with asyncio_patch("gns3server.compute.docker.DockerVM._get_container_state", return_value="running"):
+        loop.run_until_complete(asyncio.async(vm.adapter_add_nio_binding(0, nio)))
+
+        loop.run_until_complete(asyncio.async(vm.adapter_update_nio_binding(0, nio)))
+    assert vm._ubridge_apply_filters.called
+
+
+def test_adapter_udpate_nio_binding_bridge_not_started(vm, loop):
+    vm._ubridge_apply_filters = AsyncioMagicMock()
+    nio = {"type": "nio_udp",
+           "lport": 4242,
+           "rport": 4343,
+           "rhost": "127.0.0.1"}
+    nio = vm.manager.create_nio(nio)
+    with asyncio_patch("gns3server.compute.docker.DockerVM._get_container_state", return_value="running"):
+        loop.run_until_complete(asyncio.async(vm.adapter_add_nio_binding(0, nio)))
+
+        loop.run_until_complete(asyncio.async(vm.adapter_update_nio_binding(0, nio)))
+    assert vm._ubridge_apply_filters.called is False
+
+
 def test_adapter_add_nio_binding_invalid_adapter(vm, loop):
     nio = {"type": "nio_udp",
            "lport": 4242,

tests/handlers/api/compute/test_docker.py

@@ -124,6 +124,20 @@ def test_docker_nio_create_udp(http_compute, vm):
     assert response.json["type"] == "nio_udp"
 
 
+def test_docker_update_nio(http_compute, vm):
+    with asyncio_patch("gns3server.compute.docker.docker_vm.DockerVM.adapter_update_nio_binding") as mock:
+        response = http_compute.put("/projects/{project_id}/docker/nodes/{node_id}/adapters/0/ports/0/nio".format(project_id=vm["project_id"], node_id=vm["node_id"]),
+                                    {
+                                        "type": "nio_udp",
+                                        "lport": 4242,
+                                        "rport": 4343,
+                                        "rhost": "127.0.0.1"
+                                    },
+                                    example=True)
+    assert response.status == 201, response.body.decode()
+    assert response.route == "/projects/{project_id}/docker/nodes/{node_id}/adapters/{adapter_number:\d+}/ports/{port_number:\d+}/nio"
+
+
 def test_docker_delete_nio(http_compute, vm):
     with asyncio_patch("gns3server.compute.docker.docker_vm.DockerVM.adapter_remove_nio_binding") as mock:
         response = http_compute.delete("/projects/{project_id}/docker/nodes/{node_id}/adapters/0/ports/0/nio".format(project_id=vm["project_id"], node_id=vm["node_id"]), example=True)