diff --git a/gns3server/controller/ports/port_factory.py b/gns3server/controller/ports/port_factory.py index bdcd93b9..e6807136 100644 --- a/gns3server/controller/ports/port_factory.py +++ b/gns3server/controller/ports/port_factory.py @@ -84,7 +84,6 @@ class StandardPortFactory: adapter_number += 1 if "serial_adapters" in properties: - segment_number = 0 for adapter_number in range(adapter_number, properties["serial_adapters"] + adapter_number): for port_number in range(0, port_by_adapter): ports.append(PortFactory("Serial{}/{}".format(segment_number, port_number), segment_number, adapter_number, port_number, "serial")) diff --git a/tests/controller/test_node_port_name.py b/tests/controller/test_node_port_name.py index 3fc3f70b..80dbcf5c 100644 --- a/tests/controller/test_node_port_name.py +++ b/tests/controller/test_node_port_name.py @@ -335,8 +335,8 @@ def test_list_ports_iou(compute, project): "link_type": "ethernet" }, { - "name": "Serial0/0", - "short_name": "s0/0", + "name": "Serial3/0", + "short_name": "s3/0", "data_link_types": { "Frame Relay": "DLT_FRELAY", "Cisco HDLC": "DLT_C_HDLC", @@ -347,8 +347,8 @@ def test_list_ports_iou(compute, project): "link_type": "serial" }, { - "name": "Serial0/1", - "short_name": "s0/1", + "name": "Serial3/1", + "short_name": "s3/1", "data_link_types": { "Frame Relay": "DLT_FRELAY", "Cisco HDLC": "DLT_C_HDLC", @@ -359,8 +359,8 @@ def test_list_ports_iou(compute, project): "link_type": "serial" }, { - "name": "Serial0/2", - "short_name": "s0/2", + "name": "Serial3/2", + "short_name": "s3/2", "data_link_types": { "Frame Relay": "DLT_FRELAY", "Cisco HDLC": "DLT_C_HDLC", @@ -371,8 +371,8 @@ def test_list_ports_iou(compute, project): "link_type": "serial" }, { - "name": "Serial0/3", - "short_name": "s0/3", + "name": "Serial3/3", + "short_name": "s3/3", "data_link_types": { "Frame Relay": "DLT_FRELAY", "Cisco HDLC": "DLT_C_HDLC", @@ -383,8 +383,8 @@ def test_list_ports_iou(compute, project): "link_type": "serial" }, { - "name": "Serial1/0", - "short_name": "s1/0", + "name": "Serial4/0", + "short_name": "s4/0", "data_link_types": { "Frame Relay": "DLT_FRELAY", "Cisco HDLC": "DLT_C_HDLC", @@ -395,8 +395,8 @@ def test_list_ports_iou(compute, project): "link_type": "serial" }, { - "name": "Serial1/1", - "short_name": "s1/1", + "name": "Serial4/1", + "short_name": "s4/1", "data_link_types": { "Frame Relay": "DLT_FRELAY", "Cisco HDLC": "DLT_C_HDLC", @@ -407,8 +407,8 @@ def test_list_ports_iou(compute, project): "link_type": "serial" }, { - "name": "Serial1/2", - "short_name": "s1/2", + "name": "Serial4/2", + "short_name": "s4/2", "data_link_types": { "Frame Relay": "DLT_FRELAY", "Cisco HDLC": "DLT_C_HDLC", @@ -419,8 +419,8 @@ def test_list_ports_iou(compute, project): "link_type": "serial" }, { - "name": "Serial1/3", - "short_name": "s1/3", + "name": "Serial4/3", + "short_name": "s4/3", "data_link_types": { "Frame Relay": "DLT_FRELAY", "Cisco HDLC": "DLT_C_HDLC",