From 1a495ab31823b647d1e4f15e986e6f8eb51f378c Mon Sep 17 00:00:00 2001 From: Mark Paronyan Date: Wed, 30 Sep 2026 20:45:43 +0300 Subject: [PATCH] refactor: replace getattr with attribute access --- gns3server/compute/qemu/qemu_vm.py | 10 +++++----- gns3server/db/tasks.py | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gns3server/compute/qemu/qemu_vm.py b/gns3server/compute/qemu/qemu_vm.py index 465a7bc03..51b650839 100644 --- a/gns3server/compute/qemu/qemu_vm.py +++ b/gns3server/compute/qemu/qemu_vm.py @@ -2102,7 +2102,7 @@ class QemuVM(BaseNode): raise OSError(f"mcopy failure: return code {retcode}") async def _export_config(self): - disk_name = getattr(self, "config_disk_name") + disk_name = self.config_disk_name if not disk_name: return disk = os.path.join(self.working_dir, disk_name) @@ -2122,7 +2122,7 @@ class QemuVM(BaseNode): shutil.rmtree(config_dir, ignore_errors=True) async def _import_config(self): - disk_name = getattr(self, "config_disk_name") + disk_name = self.config_disk_name zip_file = os.path.join(self.working_dir, "config.zip") if not disk_name or not os.path.exists(zip_file): return @@ -2131,7 +2131,7 @@ class QemuVM(BaseNode): disk_tmp = disk + ".tmp" try: os.mkdir(config_dir) - shutil.copyfile(getattr(self, "config_disk_image"), disk_tmp) + shutil.copyfile(self.config_disk_image, disk_tmp) unpack_zip(zip_file, config_dir) config_files = [os.path.join(config_dir, fname) for fname in os.listdir(config_dir)] if config_files: @@ -2279,9 +2279,9 @@ class QemuVM(BaseNode): options.extend(await self._disk_interface_options(disk, disk_index, interface)) # config disk - disk_image = getattr(self, "config_disk_image") + disk_image = self.config_disk_image if disk_image and self._create_config_disk: - disk_name = getattr(self, "config_disk_name") + disk_name = self.config_disk_name disk = os.path.join(self.working_dir, disk_name) if self.hdd_disk_interface == "none": # use the HDA interface type if none has been configured for HDD diff --git a/gns3server/db/tasks.py b/gns3server/db/tasks.py index a9554c9cc..2b461f9a1 100644 --- a/gns3server/db/tasks.py +++ b/gns3server/db/tasks.py @@ -166,7 +166,7 @@ async def connect_to_db(app: FastAPI) -> None: async def disconnect_from_db(app: FastAPI) -> None: # dispose of the connection pool used by the database engine - if getattr(app.state, "_db_engine"): + if app.state._db_engine: await app.state._db_engine.dispose() log.info(f"Disconnected from database")