Merge pull request #2347 from SpikefishSolutions/DeadTelnetConsoleFix

Address the telnet console death bug.
This commit is contained in:
Jeremy Grossmann 2024-02-09 20:33:16 +11:00 committed by GitHub
commit 16f72b4d3d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -297,9 +297,17 @@ class AsyncioTelnetServer:
reader_read = await self._get_reader(network_reader)
# Replicate the output on all clients
for connection in self._connections.values():
connection.writer.write(data)
await connection.writer.drain()
for connection_key in list(self._connections.keys()):
client_info = connection_key.get_extra_info("socket").getpeername()
connection = self._connections[connection_key]
try:
connection.writer.write(data)
await asyncio.wait_for(connection.writer.drain(), timeout=10)
except:
log.debug(f"Timeout while sending data to client: {client_info}, closing and removing from connection table.")
connection.close()
del self._connections[connection_key]
async def _read(self, cmd, buffer, location, reader):
""" Reads next op from the buffer or reader"""