mirror of
https://github.com/GNS3/gns3-server.git
synced 2026-11-19 12:45:19 +02:00
fix: refuse Docker node updates that recreate a running container
Updating any Docker node property destroys and recreates the container (the route calls DockerVM.update() as soon as the property diff is non-empty), so it discards everything written inside it. On a running node that happened silently, as a side effect of an unrelated edit: the user only saw the node restart. Refuse the update while the container is up and say what stopping it is for, like QEMU, IOU, Dynamips, VPCS, VirtualBox and VMware already do for their own restart-requiring settings. The check runs before anything is applied — a refused update leaves the node untouched — and only when the PUT really changes a property, since Web clients send the whole node back on every edit. is_running() is not reusable for the question: it reports a paused container as not running and stops crashed containers as a side effect, so DockerVM gains is_up() for "running or paused".
This commit is contained in:
3 files changed
+101
-7
No files matched your search
@@ -392,6 +392,71 @@ class TestDockerNodesRoutes:
|
||||
assert response.json()["start_command"] is None
|
||||
assert response.json()["console_http_path"] == "/"
|
||||
|
||||
async def test_docker_update_refused_while_container_is_up(
|
||||
self, app: FastAPI, compute_client: AsyncClient, vm: dict
|
||||
) -> None:
|
||||
"""
|
||||
A property change is applied by recreating the container, which throws
|
||||
away what was written inside it. While the container is up (running or
|
||||
paused) the update is refused instead of resetting the node behind the
|
||||
user's back, and the error says what stopping it would cost.
|
||||
"""
|
||||
|
||||
for state in ("running", "paused"):
|
||||
with asyncio_patch("gns3server.compute.docker.docker_vm.DockerVM.update") as mock:
|
||||
with asyncio_patch(
|
||||
"gns3server.compute.docker.docker_vm.DockerVM._get_container_state", return_value=state
|
||||
):
|
||||
response = await compute_client.put(
|
||||
app.url_path_for(
|
||||
"compute:update_docker_node", project_id=vm["project_id"], node_id=vm["node_id"]
|
||||
),
|
||||
json={"console_type": "vnc"},
|
||||
)
|
||||
|
||||
assert response.status_code == 409
|
||||
assert "must be stopped" in response.json()["message"]
|
||||
assert "console_type" in response.json()["message"]
|
||||
assert not mock.called
|
||||
|
||||
# the refused update left the node exactly as it was
|
||||
response = await compute_client.get(
|
||||
app.url_path_for("compute:get_docker_node", project_id=vm["project_id"], node_id=vm["node_id"])
|
||||
)
|
||||
assert response.json()["console_type"] == "telnet"
|
||||
|
||||
async def test_docker_update_without_change_is_allowed_while_container_is_up(
|
||||
self, app: FastAPI, compute_client: AsyncClient, vm: dict
|
||||
) -> None:
|
||||
"""
|
||||
Clients send the whole node back on every edit: a PUT that changes
|
||||
nothing must not be refused just because the container is running.
|
||||
"""
|
||||
|
||||
with asyncio_patch("gns3server.compute.docker.docker_vm.DockerVM._get_container_state", return_value="running"):
|
||||
response = await compute_client.put(
|
||||
app.url_path_for("compute:update_docker_node", project_id=vm["project_id"], node_id=vm["node_id"]),
|
||||
json={"name": "DOCKER-TEST-1", "console_type": "telnet"},
|
||||
)
|
||||
assert response.status_code == 200
|
||||
|
||||
async def test_docker_update_stopped_container_is_recreated(
|
||||
self, app: FastAPI, compute_client: AsyncClient, vm: dict
|
||||
) -> None:
|
||||
"""A stopped container has no live state to lose: the change applies."""
|
||||
|
||||
with asyncio_patch("gns3server.compute.docker.docker_vm.DockerVM.update") as mock:
|
||||
with asyncio_patch(
|
||||
"gns3server.compute.docker.docker_vm.DockerVM._get_container_state", return_value="exited"
|
||||
):
|
||||
response = await compute_client.put(
|
||||
app.url_path_for("compute:update_docker_node", project_id=vm["project_id"], node_id=vm["node_id"]),
|
||||
json={"console_type": "vnc"},
|
||||
)
|
||||
assert response.status_code == 200
|
||||
assert mock.called
|
||||
assert response.json()["console_type"] == "vnc"
|
||||
|
||||
async def test_docker_start_capture(self, app: FastAPI, compute_client: AsyncClient, vm: dict) -> None:
|
||||
|
||||
url = app.url_path_for(
|
||||
|
||||
Reference in new issue
Block a user