NgTech-LTD/gns3-server
2
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2026-08-30 14:00:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

test: simplify class registration assertions in custom netmiko tests

Browse Source 
Refactored test assertions for Huawei CE, Ruijie, and VPCS telnet drivers to compare only class names instead of full module paths. This change reduces test brittleness when classes are imported via different module paths while maintaining validation of correct class registration in CLASS_MAPPER and CLASS_MAPPER_BASE.
This commit is contained in:
YueGuobin 2026-03-17 22:45:02 +08:00
parent 55c7d249fb
commit 0b741dd834
3 changed files with 9 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_huawei_ce.py
View File

@ -52,19 +52,13 @@ class TestHuaweiTelnetCEDriver(unittest.TestCase):
# Check CLASS_MAPPER
self.assertIn("gns3_huawei_telnet_ce", CLASS_MAPPER)
registered_class = CLASS_MAPPER["gns3_huawei_telnet_ce"]
# Compare by module+name since class may be imported via different paths
self.assertEqual(
(registered_class.__module__, registered_class.__name__),
(self.HuaweiTelnetCE.__module__, self.HuaweiTelnetCE.__name__)
)
# Compare class name since class may be imported via different paths
self.assertEqual(registered_class.__name__, self.HuaweiTelnetCE.__name__)
# Check CLASS_MAPPER_BASE
self.assertIn("gns3_huawei_telnet_ce", CLASS_MAPPER_BASE)
registered_class_base = CLASS_MAPPER_BASE["gns3_huawei_telnet_ce"]
self.assertEqual(
(registered_class_base.__module__, registered_class_base.__name__),
(self.HuaweiTelnetCE.__module__, self.HuaweiTelnetCE.__name__)
)
self.assertEqual(registered_class_base.__name__, self.HuaweiTelnetCE.__name__)
def test_inheritance_from_huawei_base(self):
"""Test that GNS3HuaweiTelnetCE inherits from HuaweiBase."""

12
gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_ruijie_telnet.py
View File

@ -52,19 +52,13 @@ class TestRuijieTelnetEnhancedDriver(unittest.TestCase):
# Check CLASS_MAPPER
self.assertIn("gns3_ruijie_telnet", CLASS_MAPPER)
registered_class = CLASS_MAPPER["gns3_ruijie_telnet"]
# Compare by module+name since class may be imported via different paths
self.assertEqual(
(registered_class.__module__, registered_class.__name__),
(self.RuijieTelnetEnhanced.__module__, self.RuijieTelnetEnhanced.__name__)
)
# Compare class name since class may be imported via different paths
self.assertEqual(registered_class.__name__, self.RuijieTelnetEnhanced.__name__)
# Check CLASS_MAPPER_BASE
self.assertIn("gns3_ruijie_telnet", CLASS_MAPPER_BASE)
registered_class_base = CLASS_MAPPER_BASE["gns3_ruijie_telnet"]
self.assertEqual(
(registered_class_base.__module__, registered_class_base.__name__),
(self.RuijieTelnetEnhanced.__module__, self.RuijieTelnetEnhanced.__name__)
)
self.assertEqual(registered_class_base.__name__, self.RuijieTelnetEnhanced.__name__)
def test_inheritance_from_ruijie_os_base(self):
"""Test that RuijieTelnetEnhanced inherits from RuijieOSBase."""

12
gns3server/agent/gns3_copilot/utils/custom_netmiko/tests/test_vpcs_telnet.py
View File

@ -54,19 +54,13 @@ class TestVPCSTelnetDriver(unittest.TestCase):
# Check CLASS_MAPPER
self.assertIn("gns3_vpcs_telnet", CLASS_MAPPER)
registered_class = CLASS_MAPPER["gns3_vpcs_telnet"]
# Compare by module+name since class may be imported via different paths
self.assertEqual(
(registered_class.__module__, registered_class.__name__),
(self.VPCSTelnet.__module__, self.VPCSTelnet.__name__)
)
# Compare class name since class may be imported via different paths
self.assertEqual(registered_class.__name__, self.VPCSTelnet.__name__)
# Check CLASS_MAPPER_BASE
self.assertIn("gns3_vpcs_telnet", CLASS_MAPPER_BASE)
registered_class_base = CLASS_MAPPER_BASE["gns3_vpcs_telnet"]
self.assertEqual(
(registered_class_base.__module__, registered_class_base.__name__),
(self.VPCSTelnet.__module__, self.VPCSTelnet.__name__)
)
self.assertEqual(registered_class_base.__name__, self.VPCSTelnet.__name__)
def test_inheritance_from_base_connection(self):
"""Test that VPCSTelnet inherits from BaseConnection."""