diff --git a/gns3server/api/routes/controller/acl.py b/gns3server/api/routes/controller/acl.py index 7febf226b..a454a1d61 100644 --- a/gns3server/api/routes/controller/acl.py +++ b/gns3server/api/routes/controller/acl.py @@ -80,7 +80,7 @@ def _iter_route_paths(routes: Sequence[BaseRoute], prefix: str = "", include_mou yield from _iter_route_paths(mounted_routes, _join_paths(prefix, route.path), include_mounted_routes) -@router.get("/endpoints", status_code=status.HTTP_201_CREATED, dependencies=[Depends(has_privilege("ACE.Audit"))]) +@router.get("/endpoints", dependencies=[Depends(has_privilege("ACE.Audit"))]) async def endpoints( users_repo: UsersRepository = Depends(get_repository(UsersRepository)), rbac_repo: RbacRepository = Depends(get_repository(RbacRepository)), diff --git a/gns3server/api/routes/controller/controller.py b/gns3server/api/routes/controller/controller.py index e1f03b7e3..1b8667ec8 100644 --- a/gns3server/api/routes/controller/controller.py +++ b/gns3server/api/routes/controller/controller.py @@ -146,7 +146,7 @@ def get_iou_license() -> schemas.IOULicense: @router.put( "/iou_license", dependencies=[Depends(get_current_active_user)], - status_code=status.HTTP_201_CREATED, + status_code=status.HTTP_200_OK, response_model=schemas.IOULicense, ) async def update_iou_license(iou_license: schemas.IOULicense) -> schemas.IOULicense: diff --git a/gns3server/api/routes/controller/projects.py b/gns3server/api/routes/controller/projects.py index 5b4e6e51e..264dd475b 100644 --- a/gns3server/api/routes/controller/projects.py +++ b/gns3server/api/routes/controller/projects.py @@ -495,7 +495,7 @@ async def close_project(project: Project = Depends(dep_project)) -> None: @router.post( "/{project_id}/open", - status_code=status.HTTP_201_CREATED, + status_code=status.HTTP_200_OK, response_model=schemas.Project, responses={**responses, 409: {"model": schemas.ErrorMessage, "description": "Could not open project"}}, dependencies=[Depends(has_privilege("Project.Allocate"))], diff --git a/gns3server/api/routes/controller/snapshots.py b/gns3server/api/routes/controller/snapshots.py index eddcd029e..b0ed679f5 100644 --- a/gns3server/api/routes/controller/snapshots.py +++ b/gns3server/api/routes/controller/snapshots.py @@ -106,7 +106,7 @@ async def delete_snapshot( @router.post( "/{snapshot_id}/restore", - status_code=status.HTTP_201_CREATED, + status_code=status.HTTP_200_OK, response_model=schemas.Project, dependencies=[Depends(has_privilege("Snapshot.Restore"))], ) diff --git a/tests/api/routes/controller/test_acl.py b/tests/api/routes/controller/test_acl.py index 8cbb19655..b67369ff4 100644 --- a/tests/api/routes/controller/test_acl.py +++ b/tests/api/routes/controller/test_acl.py @@ -161,3 +161,8 @@ class TestACLRoutes: # the ACE should have been deleted after deleting the project assert not await rbac_repo.get_ace_by_path(path) + + async def test_get_endpoints(self, app: FastAPI, client: AsyncClient) -> None: + + response = await client.get(app.url_path_for("endpoints")) + assert response.status_code == status.HTTP_200_OK diff --git a/tests/api/routes/controller/test_controller.py b/tests/api/routes/controller/test_controller.py index 4ef729543..d35d2ea17 100644 --- a/tests/api/routes/controller/test_controller.py +++ b/tests/api/routes/controller/test_controller.py @@ -70,3 +70,10 @@ class TestControllerRoutes: response = await client.get(app.url_path_for("statistics")) assert response.status_code == status.HTTP_200_OK + + async def test_update_iou_license(self, app: FastAPI, client: AsyncClient) -> None: + + license_settings = {"iourc_content": "[license]\ngns3vm = 1234567890abcdef;", "license_check": False} + response = await client.put(app.url_path_for("update_iou_license"), json=license_settings) + assert response.status_code == status.HTTP_200_OK + assert response.json() == license_settings diff --git a/tests/api/routes/controller/test_projects.py b/tests/api/routes/controller/test_projects.py index 4f00b2f98..71e2e37be 100644 --- a/tests/api/routes/controller/test_projects.py +++ b/tests/api/routes/controller/test_projects.py @@ -216,7 +216,7 @@ class TestControllerProjectRoutes: with asyncio_patch("gns3server.controller.project.Project.open", return_value=True) as mock: response = await client.post(app.url_path_for("open_project", project_id=project.id)) - assert response.status_code == status.HTTP_201_CREATED + assert response.status_code == status.HTTP_200_OK assert mock.called async def test_load_project(self, app: FastAPI, client: AsyncClient, project: Project, config) -> None: diff --git a/tests/api/routes/controller/test_snapshots.py b/tests/api/routes/controller/test_snapshots.py index 5e0faf1f4..73f6e1ca7 100644 --- a/tests/api/routes/controller/test_snapshots.py +++ b/tests/api/routes/controller/test_snapshots.py @@ -72,7 +72,7 @@ class TestSnapshotRoutes: response = await client.post( app.url_path_for("restore_snapshot", project_id=project.id, snapshot_id=snapshot.id) ) - assert response.status_code == status.HTTP_201_CREATED + assert response.status_code == status.HTTP_200_OK assert response.json()["name"] == project.name async def test_create_snapshot(self, app: FastAPI, client: AsyncClient, project: Project) -> None: