From 066b7076c096d709331241eeeae185f9ab81d68f Mon Sep 17 00:00:00 2001 From: YueGuobin Date: Wed, 10 Jun 2026 00:46:10 +0800 Subject: [PATCH] Add comment about rootful Docker permissions at container start Rootful Docker recreates volume mount points as root on start, preventing the GNS3 process from writing files into node directories while the container is running. self._fix_permissions() would resolve this but is currently only called at container stop time. --- gns3server/compute/docker/docker_vm.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gns3server/compute/docker/docker_vm.py b/gns3server/compute/docker/docker_vm.py index 53f8dcffb..8c139cdfd 100644 --- a/gns3server/compute/docker/docker_vm.py +++ b/gns3server/compute/docker/docker_vm.py @@ -669,6 +669,12 @@ class DockerVM(BaseNode): await self.manager.query("POST", f"containers/{self._cid}/start") await asyncio.sleep(0.5) # give the Docker container some time to start + # Fix host-side directory ownership after Docker (re)creates + # volume mount points as root (rootful Docker only). + # This allows the GNS3 process to write files into node directories + # while the container is running. Permissions are recorded and + # restored inside the container by init.sh on next startup. + # await self._fix_permissions() self._namespace = await self._get_namespace() await self._start_ubridge(require_privileged_access=True)